GNOME Bugzilla – Bug 305046
GThumb prints comments incorrectly wrapping wrong
Last modified: 2006-11-01 14:06:05 UTC
Distribution/Version: Gentoo When I print a picture with a long comment, it wraps only part of the word instead of the whole word. For example: A string like this might become A string like this mi ght become
Confirmed in CVS HEAD (2.9.0). This is actually pretty annoying. Marking priority as "high". - Mike
I think the function pci_get_next_line_to_print_delimiter in libgthumb/print-callbacks.c needs to be modified so that it returns the string and line width only up to the last space before max_width. Right now, it stops at the first newline or the first character after max_width. - Mike
Created attachment 75151 [details] [review] Patch to fix comment wrapping, comment saving, and series renaming. Paolo, Here is a patch that: 1. Fixes bug 305046, by making printed comments wrap between words, rather than blindly wrapping in the middle of words. 2. Fixes bug 338623 and bug 339037, by adding a "%e" file-extension symbol when renaming a series of files. This allows extensions to be changed, and fixes a crash when files without extensions were renamed. 3. Fixes bug 310647. The "Close" and "Save" buttons in the comments dialog have been changed to "Cancel" and "OK". The save is automatic when OK is clicked. I find this much more intuitive. Similar changes were made to the categories dialog.
Paolo, I forgot to say "Please commit". - Mike
Patch committed to CVS HEAD.