After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 304482 - GtkComboBoxEntry editable entry should be centered vertically
GtkComboBoxEntry editable entry should be centered vertically
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkComboBox
2.6.x
Other All
: Normal normal
: Small fix
Assigned To: gtk-bugs
gtk-bugs
Depends on: 307199
Blocks:
 
 
Reported: 2005-05-17 09:33 UTC by Rob Staudinger
Modified: 2007-01-02 14:26 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
screenshot showing problem (14.31 KB, image/png)
2005-05-17 09:35 UTC, Rob Staudinger 		  Details
testcase (1.19 KB, application/x-glade)
2005-05-18 21:50 UTC, Rob Staudinger 		  Details
Center the text in GtkEntry. (514 bytes, patch)
2005-08-13 15:21 UTC, Richard Stellingwerff 		none Details | Review
Center the text in GtkEntry (1.21 KB, patch)
2005-08-13 16:16 UTC, Richard Stellingwerff 		none Details | Review
updated to avoid bitrot (1.30 KB, patch)
2006-12-26 14:18 UTC, Kjartan Maraas 		none Details | Review

Description Rob Staudinger 2005-05-17 09:33:17 UTC 
Please describe the problem:
Unlike a GtkComboBox' currently selected item, the active item of a
GtkComboBoxEntry is not centered vertically if the widget grows in size.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Rob Staudinger 2005-05-17 09:35:20 UTC 
Created attachment 46535 [details]
screenshot showing problem

It would be really cool to have this fixed i could use a GtkComboBoxEntry for
the font-size in AbiWord.
Comment 2 Matthias Clasen 2005-05-18 20:51:03 UTC 
Do you have a testcase showing the problematic behaviour ? It seems to work fine
for me.
Comment 3 Rob Staudinger 2005-05-18 21:50:37 UTC 
Created attachment 46623 [details]
testcase

Just open the attached .glade file in glade, type something into the
GtkComboBoxEntry and the resize the window. The text always stays aligned
left-top.
Comment 4 Matthias Clasen 2005-06-10 19:42:41 UTC 
This is really a GtkEntry issue
Comment 5 Richard Stellingwerff 2005-08-13 15:21:07 UTC 
Created attachment 50649 [details] [review]
Center the text in GtkEntry.

Patch against CVS HEAD. Tested with several applications.
Comment 6 Richard Stellingwerff 2005-08-13 16:16:38 UTC 
Created attachment 50651 [details] [review]
Center the text in GtkEntry

Previous patch had problems with expanding GtkEntry. Normal GtkEntry widget
doesn't expand the frame like the GtkComboBoxEntry does. This time, it centers
the text in the frame, as opposed to the full height of the widget.

Patch against CVS HEAD.
Comment 7 Kjartan Maraas 2006-12-26 14:18:37 UTC 
Created attachment 78905 [details] [review]
updated to avoid bitrot
Comment 8 Matthias Clasen 2007-01-02 14:26:35 UTC 
2007-01-02  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkentry.c (get_text_area_size): Center in the frame.
        (#304482, Rob Staudinger, patch by  Richard Stellingwerff)