GNOME Bugzilla – Bug 303937
Evolution crashes on receiving drag+drop event.
Last modified: 2007-07-27 06:40:01 UTC
Distribution: Fedora Core release 3 (Heidelberg) Package: Evolution Severity: normal Version: GNOME2.8.0 unspecified Gnome-Distributor: Red Hat, Inc Synopsis: Evolution crashes on receiving drag+drop event. Bugzilla-Product: Evolution Bugzilla-Component: Miscellaneous Bugzilla-Version: unspecified BugBuddy-GnomeVersion: 2.0 (2.8.0) Description: Description of the crash: Evolution crashed on receiving drag+drop event. Steps to reproduce the crash: 1. Start Evolution. 2. Now be quick. Drag an icon from the desktop into the message list pane BEFORE any mail servers have been queried. Expected Results: Evolution ignore the event. How often does this happen? Always. Debugging Information: Backtrace was generated from '/usr/bin/evolution' (no debugging symbols found)...Using host libthread_db library "/lib/tls/libthread_db.so.1". (no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...[Thread debugging using libthread_db enabled] [New Thread -1208568128 (LWP 5760)] [New Thread -1264006224 (LWP 5789)] [Thread debugging using libthread_db enabled] [New Thread -1208568128 (LWP 5760)] [New Thread -1264006224 (LWP 5789)] [New Thread -1274496080 (LWP 5788)] [New Thread -1285071952 (LWP 5786)] [New Thread -1243026512 (LWP 5782)] [New Thread -1232536656 (LWP 5781)] [New Thread -1222046800 (LWP 5780)] [New Thread -1211556944 (LWP 5779)] (no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...[Thread debugging using libthread_db enabled] [New Thread -1208568128 (LWP 5760)] [New Thread -1264006224 (LWP 5789)] (no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...0x00adb7a2 in _dl_sysinfo_int80 () from /lib/ld-linux.so.2
+ Trace 59554
Thread 3 (Thread -1274496080 (LWP 5788))
------- Bug moved to this database by unknown@bugzilla.gnome.org 2005-05-12 17:14 UTC -------
I am able to reproduce the crash with 2.2.x version of evolution on NLD SP1 with IMAP. Debugging Information:
+ Trace 59585
Thread 5 (Thread 1108982704 (LWP 7394))
+ Trace 59586
sorry for the duplicate comments.
probably just needs to check the folder != NULL
should be retested, see last comment by michael. removing old target milestone.
Created attachment 92039 [details] [review] proposed patch for evolution; I did it based on comment #4 and to be honest, I could not test it, because I'm not so quick :)
I dont think this much to be done. In ml_tree_drag_data_received return if it is null. ALso dont use g_return_if_fail. It is a valid case and not a error sitn. It would raise a unnecessary critical-warning.
Created attachment 92446 [details] [review] proposed patch for evolution; I removed that g_return_if_fail but kept all other, even you've right it's a bit more paranoic :) btw, the function you mentioned is a "typo" I think, because I didn't touch that one, maybe you meant ml_drop_async_drop.
Hmm I think Im right. You dont have to check if folder is null or not. You anyway skipping everything if that is null. Why post that task, if the folder is null?
Created attachment 92457 [details] [review] proposed patch for evolution; I'm sorry I didn't get it at the first moment, you've right, this is better.
Looks good. Please commit
Committed to trunk. Committed revision 33859.