GNOME Bugzilla – Bug 303573
Exceptions raised in a child watch handler are silently swallowed
Last modified: 2006-01-09 14:13:22 UTC
Distribution/Version: Fedora Core If the callback passed to gobject.child_watch_add() raises an exception, no traceback is printed. Patch and test cases provided below
Created attachment 46242 [details] test-mainloop.py
Created attachment 46243 [details] [review] pygtk-dont-silently-swallow-exceptions-in-child-watch-handlers.patch
Looks good. Can you please adapt your test to use unittest and add it as testsuite/test_mainloop.py? (so make check/distcheck catches this).
Created attachment 46248 [details] [review] pygtk-dont-silently-swallow-exceptions-in-child-watch-handlers.patch
Thanks, checked in. (I modified test_mainloop.py slightly)
You forgot the change to include test_mainloop.py in Makefile.am
That seems strange, since it shows up here: http://cvs.gnome.org/viewcvs/gnome-python/pygtk/tests/Makefile.am?r1=1.16&r2=1.17 Are you really running latest cvs?
My bad, I just didn't see that it had moved up the list :-) (I wondered how distcheck had managed to pass for you :-)