After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 303544 - web gallery exif
web gallery exif
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
2.6.x
Other Linux
: Normal normal
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on:
Blocks:
 
 
Reported: 2005-05-09 10:53 UTC by Emmanuel Touzery
Modified: 2005-11-08 18:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch that adds EXIF data to resized images (2.27 KB, patch)
2005-05-09 10:55 UTC, Emmanuel Touzery
none Details | Review
better patch (2.11 KB, patch)
2005-05-09 10:59 UTC, Emmanuel Touzery
none Details | Review
fixed patch, previous patches were bogus... (2.50 KB, patch)
2005-05-09 19:01 UTC, Emmanuel Touzery
none Details | Review

Description Emmanuel Touzery 2005-05-09 10:53:40 UTC
When gthumb resizes the pictures for web gallery, the EXIF data is not present
in the resized images. If you say eg. 800x600 maximum size of the pictures on
the web gallery, you can't see the EXIF info for any image exported by the web
gallery, since all the images are resized.

I made a patch to fix that problem, i'll add it in this bug report now.
Comment 1 Emmanuel Touzery 2005-05-09 10:55:13 UTC
Created attachment 46231 [details] [review]
patch that adds EXIF data to resized images

with this patch applied, gthumb will re-add the EXIF data to the resized images
of the web gallery. this is consistent with GIMP, EOG and most photo software
behaviour, and gives much more information for the viewer of the web gallery.
Comment 2 Emmanuel Touzery 2005-05-09 10:59:21 UTC
Created attachment 46232 [details] [review]
better patch

doh, the previous patch had some unnecessary lines, this one cleans up and
removes them.
Comment 3 Emmanuel Touzery 2005-05-09 11:10:11 UTC
sorry, just to add a last thing. i wanted to say this is even more relevant now
that things like FxIF exist, see
http://ted.mielczarek.org/code/mozilla/fxif/

this allows to see EXIF info of images from within firefox. so for certain type
of users, EXIF info on the web is becoming absolutely standard.
Comment 4 Emmanuel Touzery 2005-05-09 19:01:19 UTC
Created attachment 46253 [details] [review]
fixed patch, previous patches were bogus...

OMG, I'm so sorry, the previous patches are wrong because I thought jpeg_data
is the EXIF plus some metadata, I didn't realise it was actually the whole
picture. so my previous patches save the thumbnail images in the same
resolution than the original images!
this patch correctly copies _only_ the EXIF from the original image and
therefore does what it should...
Comment 5 Emmanuel Touzery 2005-06-03 09:07:48 UTC
i'm using this patch in my copy of gthumb for quite some time now, never had a
problem with it, i think this patch only has advantages, it's quite
uncontroversial and a good feature. please consider applying it to gthumb's
source code.
Comment 6 Paolo Bacchilega 2005-06-21 17:35:49 UTC
Patch applied to the gthumb-2-6 branch.
I'll apply it to HEAD as soon as possible.

Thank you.
Comment 7 Nelson Benitez 2005-09-22 18:21:22 UTC
This bug is fixed, also in HEAD, so it needs to be closed... :)
Comment 8 Paolo Bacchilega 2005-09-23 13:05:22 UTC
closing...
Comment 9 Emmanuel Touzery 2005-11-08 17:48:25 UTC
In 2.6.5 from ubuntu breezy no exif are generated. so it seems the bug is still
there.
remember i'm setting a max picture size so there nowhere the picture at original
size on the website.
Comment 10 Paolo Bacchilega 2005-11-08 18:06:50 UTC
latest stable version is 2.6.8, from the ChangeLog:

2005-06-21  Paolo Bacchilega  <paobac@cvs.gnome.org>

        * src/catalog-web-exporter.c (save_resized_image_cb)
        (copy_exif_from_orig): new function
        (save_thumbnail_cb, save_image_preview_cb):

        Re-add the exif data to the resized images.

        Fixes bug #303544.  Patch by Emmanuel Touzery.
Comment 11 Emmanuel Touzery 2005-11-08 18:29:36 UTC
OK, great that it's fixed after all!
too bad ubuntu is slow to update their gthumb.