After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 301076 - incorrect copyright notice in newsprint plugin
incorrect copyright notice in newsprint plugin
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Plugins
2.2.x
Other All
: Normal major
: ---
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2005-04-18 15:23 UTC by Stanislav Brabec
Modified: 2008-01-15 12:52 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Stanislav Brabec 2005-04-18 15:23:23 UTC
License for parts of newsprint plugin is GPL incompatible and maybe does not
allow to distribute it as part of the GIMP.

 *  % NOTICE: This code is copyrighted by Adobe Systems Incorporated, and
 *  % may not be reproduced for sale except by permission of Adobe Systems
 *  % Incorporated. Adobe Systems Incorporated grants permission to use
 *  % this code for the development of screen sets for use with Adobe
 *  % Accurate Screens software, as long as the copyright notice remains
 *  % intact.
Comment 1 Sven Neumann 2005-04-18 15:41:36 UTC
Have you also looked at the code in question?

static gdouble
spot_PSsquare (gdouble x,
               gdouble y)
{
  gdouble ax = ABS (x);
  gdouble ay = ABS (y);

  return ((ax + ay) > 1 ?
          ((ay - 1) * (ay - 1) + (ax - 1) * (ax - 1)) - 1 :
          1 - (ay * ay + ax * ax));
}

static gdouble
spot_PSdiamond (gdouble x,
                gdouble y)
{
  gdouble ax = ABS (x);
  gdouble ay = ABS (y);

  return ((ax + ay) <= 0.75 ? 1 - (ax * ax + ay * ay) :
          ((ax + ay) <= 1.23 ?  1 - ((ay * 0.76) + ax) :
           ((ay - 1) * (ay - 1) + (ax - 1) * (ax - 1)) -1));
}

It it ridiculous to try to cover these lines with any copyright whatsoever. It
is commonly accepted that a few lines of code, especially if they just represent
a simple algorithm, cannot be copyrighted. If it helps you, I can show you
written word from Richard Stallmann that backs up this point of view. Closing as
NOTABUG.
Comment 2 Joao S. O. Bueno 2005-04-18 16:08:13 UTC
However, 
the Adobe copyright notice is in the code - and as it reads now, it is GPL 
incompatible indeed. The wording "this code ... may not be reproduced for 
sale" is stamped right there, in the code that comes with the GIMP, not on a 
letter some Adobe lawyer sent the GIMP developers. 
 
If it is as you say the Adobe copyright notice should be taken down then. 
Possibly instead of the full copyright note a  notice just like one that would 
be used in quoting an academic work could be placed there. 
 
I am not reoppening the bug, since I believe the better thing to do is to 
modify the Adobe related comments. But it should be done. 
 
(Btw beware, now it lies under the all seeing eye of Adobe-Macromedia(tm) 
systems inc.) 
 
 
Comment 3 Sven Neumann 2005-04-18 16:27:55 UTC
Joao, did you seriously believe we would do nothing about this?
Comment 4 Raphaël Quinet 2005-04-18 16:29:59 UTC
This should be the final nail in the coffin:

2005-04-18  Raphaël Quinet  <raphael@gimp.org>

	* plug-ins/common/newsprint.c: Added comment to clarify the
	copyright notice (bug #301076).
Comment 5 Manish Singh 2005-04-18 19:02:33 UTC
The real final nail:

2005-04-18  Manish Singh  <yosh@gimp.org>

        * plug-ins/common/newsprint.c: Redo comment for spot_PSsquare
        and spot_PSdiamonds, since the code was not a derived work in
        the copyright sense. It is a C implementation of the same
        algorithm.