After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 300884 - Preview of image in the File selector when choosing picture of a contact.
Preview of image in the File selector when choosing picture of a contact.
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Contacts
2.6.x
Other All
: Normal minor
: ---
Assigned To: Srinivasa Ragavan
Evolution QA team
Depends on:
Blocks: 327508 327510
 
 
Reported: 2005-04-16 18:15 UTC by Lionel Dricot
Modified: 2013-09-13 00:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.36 KB, patch)
2006-03-02 05:30 UTC, Devashish Sharma 		none Details | Review

Description Lionel Dricot 2005-04-16 18:15:47 UTC 
It would be great to add a preview of images in the Gtk file chooser when you
are looking for an image to add to a contact.

(click on the head icon in the contact editor)

Other information:
I'm running Ubuntu Hoary with Evo 2.2.
Comment 1 André Klapper 2005-04-17 01:06:08 UTC 
is the a gtk issue (it would be a NOTGNOME issue then and has to be closed) or 
is it that evolution explicitly must tell the file chooser dialog to make an 
instance with a preview window included?
Comment 2 André Klapper 2005-04-29 09:18:10 UTC 
very related to bug 302388
Comment 3 Calum Benson 2005-07-28 10:38:13 UTC 
Apologies for any spam... cc'ing usability-maint on all Evolution usability
bugs. Filter on EVO-USABILITY-SPAM to ignore.
Comment 4 Devashish Sharma 2006-02-01 05:57:33 UTC 
Please file a bug with gtk under gtkfilechooser component.
Comment 5 André Klapper 2006-02-01 09:10:35 UTC 
then why IS this already possible when opening files in gimp? don't tell me this is a gtk issue... :-/
Comment 6 Devashish Sharma 2006-02-01 11:08:31 UTC 
Fix committed to cvs head.
File selector now shows the preview of the image.
Comment 7 André Klapper 2006-02-01 17:38:19 UTC 
hi devashish,
great stuff, but i doubt that it is HIG-compliant: if you use the arrow up/down buttons and have both images and non-image files in the folder, the buttons at the buttom ("cancel", "open", "no image") jump left and right, which is a hig-violation:

"Always show a window as soon as possible, but make sure your window is the
correct size before displaying it. Resizing a window after it is visible is
disorienting and gives an unpolished look to your application."

so evolution shows *all* files in the folder list and "dynamic" preview, whilst gimp shows only image files and "static" preview.

hmm. sorry that i have to reopen it (because i am *really* happy to have that in), but it's a hig-violation. :-(
Comment 8 André Klapper 2006-02-01 20:11:06 UTC 
ok, my quote is plain wrong as it refers to visibility of windows, but i'm still pretty afraid that we're violating the hig.
Comment 9 Calum Benson 2006-02-07 17:20:57 UTC 
I'd agree it certainly falls into the "undesirable" category, even if there's nothing specifically in the HIG that says "don't do it".  (I suspect there might be somewhere, but I don't know where off-hand.)
Comment 10 Devashish Sharma 2006-03-02 05:30:24 UTC 
Created attachment 60461 [details] [review]
Patch

Now it shows a static preview widget and a custom image when the image cant be shown. Please see if this can be committed.
Comment 11 Devashish Sharma 2006-03-05 11:04:46 UTC 
Fix committed to cvs head