After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 260403 - [PATCH]Evolution is not giving Warning message when tried to delete one contact from public-contact folder
[PATCH]Evolution is not giving Warning message when tried to delete one conta...
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Contacts
1.5.x (obsolete)
Other All
: Normal minor
: ---
Assigned To: Vandana
Ximian Connector QA
Depends on:
Blocks: 327514
 
 
Reported: 2004-06-18 09:11 UTC by chethan
Modified: 2013-09-10 14:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for the bug 260403 (3.41 KB, patch)
2006-04-06 11:14 UTC, Vandana 		needs-work Details | Review
Patch for the Bug (3.04 KB, patch)
2006-05-25 07:34 UTC, Vandana 		rejected Details | Review
Patch for the above bug (2.83 KB, patch)
2006-05-26 03:46 UTC, Vandana 		needs-work Details | Review
Slightly modified patch (2.27 KB, patch)
2006-07-24 11:53 UTC, Sushma Rai 		needs-work Details | Review
Patch for the above bug (2.86 KB, patch)
2006-07-25 05:11 UTC, Vandana 		needs-work Details | Review
patch (3.04 KB, patch)
2006-07-25 10:35 UTC, Vandana 		none Details | Review
patch (3.09 KB, patch)
2006-07-25 10:57 UTC, Vandana 		needs-work Details | Review
Patch (2.50 KB, patch)
2006-08-07 08:09 UTC, Sushma Rai 		committed Details | Review

Description chethan 2004-06-18 09:11:06 UTC 
Steps to reproduce the problem:
1. Go to contacts view. Select public-contacts folder
2. Select one contact which some others had entered(Not owned by you)
3. Delete the contact

Actual Results:
Contact wont be deleted. 

Expected Results:
Evolution should give one warning message that you dont have permission to
delete.

How often does this happen? 
Everytime

Additional Information:
Working fine only evo should give error message.
Comment 1 Krishnan R 2005-07-18 07:40:57 UTC 
Reassiging these to the maintainer 'surfy'.
Comment 2 Vandana 2006-04-06 11:14:27 UTC 
Created attachment 62840 [details] [review]
Patch for the bug 260403

The following patch should fix this bug .

Thank you.
Comment 3 Sushma Rai 2006-04-18 15:22:08 UTC 
Why do you need a EContactDeleteCallback structure?
You are not using it in before_deleted_cb().

Just adding a callback function and handling the status is enough.

Also, instead of eab_error_dialog() use add a error code and string to 
errors xml file and use e_error_run()

Instead of before_deleted_cb() use dome better name.

remove the comment /* no callback specified*/, as you are providing one.
Comment 4 Vandana 2006-05-25 07:34:47 UTC 
Created attachment 66174 [details] [review]
Patch for the Bug

Attached a Patch for the above bug, with the above mentioned specified changes
Comment 5 Sushma Rai 2006-05-25 08:34:26 UTC 
I still see "_EContactDeleteCallback",
eab_error_dialog(), before_deleted_cb() and /* no callback specified*/
Comment 6 Vandana 2006-05-26 03:46:04 UTC 
Created attachment 66239 [details] [review]
Patch for the above bug

Sorry for teh inconvenience . I attached the wrong patch by mistake !
Comment 7 Sushma Rai 2006-07-24 11:53:09 UTC 
Created attachment 69488 [details] [review]
Slightly modified patch
Comment 8 Sushma Rai 2006-07-24 12:01:55 UTC 
Permission denied needs to be displayed only if the error is E_BOOK_ERROR_PERMISSION_DENIED, not for all cases.
Comment 9 Vandana 2006-07-25 05:11:35 UTC 
Created attachment 69552 [details] [review]
Patch for the above bug

Attached is a patch with the right check.
Comment 10 Sushma Rai 2006-07-25 10:09:09 UTC 
Add a "default" case also where you can throw some generic error,
Comment 11 Vandana 2006-07-25 10:35:35 UTC 
Created attachment 69563 [details] [review]
patch
Comment 12 Vandana 2006-07-25 10:57:12 UTC 
Created attachment 69564 [details] [review]
patch
Comment 13 Sushma Rai 2006-08-07 08:09:39 UTC 
Created attachment 70362 [details] [review]
Patch
Comment 14 Sushma Rai 2006-08-07 08:52:12 UTC 
committed the patch to cvs head. And moving the bug to 
correct component Evolution->addressbook.