GNOME Bugzilla – Bug 246227
Save Search dialog - label suggestions
Last modified: 2005-12-20 10:17:46 UTC
Save Search dialog - To open, choose Search > Save Search. Or choose Search > Edit Saved Searches, click Add. 1. s/If/Find items that meet the following criteria 2. s/Execute actions/Find items: 3. s/if any criteria are met/If any criteria are met 4. s/if all criteria are met/If all criteria are met 5. Add the following titles to the columns in the table of criteria: Field, Condition, Value. This bug blocks bug 246224.
Can you explain your thoughts behing suggestion #5 above (add labels to the table columns) ?
I thought that adding these labels would make the functionality a little clearer - users will have to do less work to figure out what these dialog elements are for. Maybe it's a bit of overkill, but I do think it is better to err on the side of clarity.
Created attachment 49965 [details] [review] fixes the UI suggestions for "Advanced Search" and "Save Search"
Eugene: those title labels won't always match - filter rows are free-form, they can have any type of input widgets and so won't necessarily correspond to your labels. e.g. there is at least one which is: field value condition value and some that are simply field value or field condition
The patch ( attachment id=51513 ) also fixes the bug#246227 . The "Advanced Search " and "Save Search" dialogs reuse the same part of the code .
Fixed to head.