After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 240252 - LOG(e...) syntax error
LOG(e...) syntax error
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Calendar
pre-1.5 (obsolete)
Other All
: Normal enhancement
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
Depends on:
Blocks: 239034
 
 
Reported: 2003-03-25 13:19 UTC by Patton Gao
Modified: 2013-09-10 14:03 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Patch for this bug (693 bytes, patch)
2003-03-25 13:35 UTC, Patton Gao
none Details | Review
Patch for total 3 files (2.67 KB, patch)
2003-03-26 00:35 UTC, Patton Gao
none Details | Review
different fix (27.95 KB, patch)
2003-04-03 02:44 UTC, Not Zed
none Details | Review

Description Patton Gao 2003-03-25 13:19:48 UTC
When building Evolution on Solaris 8 with Forte, I met error as follows:

"address-conduit.c", line 60: syntax error in macro parameters
"address-conduit.c", line 65: syntax error in macro parameters
"address-conduit.c", line 66: syntax error in macro parameters
"address-conduit.c", line 615: warning: label should be followed by a
(possibly empty) statement
"address-conduit.c", line 630: warning: label should be followed by a
(possibly empty) statement
"address-conduit.c", line 645: warning: label should be followed by a
(possibly empty) statement
"address-conduit.c", line 662: warning: label should be followed by a
(possibly empty) statement
"address-conduit.c", line 879: warning: assignment type mismatch:
        pointer to unsigned char "=" pointer to char
"address-conduit.c", line 923: warning: argument #2 is incompatible with
prototype:
        prototype: pointer to unsigned char :
"/usr/local/include//pi-address.h", line 50
        argument : pointer to char
cc: acomp failed for address-conduit.c
make[3]: *** [address-conduit.lo] Error 1
make[3]: Leaving directory
`/export/home/work/evo_src_Mar25/addressbook/conduit'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/export/home/work/evo_src_Mar25/addressbook'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/export/home/work/evo_src_Mar25'
make: *** [all-recursive-am] Error 2
bash-2.03$

The content of file address-conduit.c is as follows:

    59  #ifdef DEBUG_CONDUIT
    60  #define LOG(e...) g_log (G_LOG_DOMAIN, G_LOG_LEVEL_MESSAGE, e)
    61  #else
    62  #define LOG(e...)
    63  #endif
    64
    65  #define WARN(e...) g_log (G_LOG_DOMAIN, G_LOG_LEVEL_WARNING, e)
    66  #define INFO(e...) g_log (G_LOG_DOMAIN, G_LOG_LEVEL_MESSAGE, e)
 
Forte compiler cannot explain the syntax as LOG(e...).
Comment 1 Patton Gao 2003-03-25 13:32:41 UTC
Change into:

    59  #ifdef DEBUG_CONDUIT
    60  #define LOG(e,...) g_log (G_LOG_DOMAIN, G_LOG_LEVEL_MESSAGE, e)
    61  #else
    62  #define LOG(e,...)
    63  #endif
    64
    65  #define WARN(e,...) g_log (G_LOG_DOMAIN, G_LOG_LEVEL_WARNING, e)
    66  #define INFO(e,...) g_log (G_LOG_DOMAIN, G_LOG_LEVEL_MESSAGE, e)


Compiling passed.
Comment 2 Patton Gao 2003-03-25 13:35:19 UTC
Created attachment 42166 [details] [review]
Patch for this bug
Comment 3 Patton Gao 2003-03-26 00:33:45 UTC
Other two files also have this issue:

evolution/calendar/conduits/calendar/calendtodo-conduit.c
evolution/calendar/conduits/todo/ar-conduit.c
Comment 4 Patton Gao 2003-03-26 00:35:53 UTC
Created attachment 42167 [details] [review]
Patch for total 3 files
Comment 5 Not Zed 2003-04-03 02:27:33 UTC
this patch is incorrect.

it breaks the behaviour, and it also relies on c99 standard syntax,
which we are not supporting
Comment 6 Not Zed 2003-04-03 02:44:48 UTC
Created attachment 42210 [details] [review]
different fix
Comment 7 Ettore Perazzoli 2003-04-07 17:13:29 UTC
JP committed the fix.
Comment 8 philip zhao 2003-04-10 02:23:26 UTC
This question still exists in 4.7's trunk. Notzed and Ettore, have
your patch been checked in? Thanks.
Comment 9 Gerardo Marin 2003-04-23 20:37:50 UTC
Patch commited on April 7 th. according to evolution-patches list.