GNOME Bugzilla – Bug 237917
Arbitrary entry in From: field when composing
Last modified: 2015-03-02 16:46:45 UTC
The mail composition window has a friendly popup menu of account identities to use when sending mail. However, it's not possible to enter in arbitrary values there. This is important for users who use wildcard-delivery addresses, Exim/qmail-style sub-addressing, etc.
This won't change in the foreseable future.
*** bug 256164 has been marked as a duplicate of this bug. ***
*** bug 256030 has been marked as a duplicate of this bug. ***
*** bug 242442 has been marked as a duplicate of this bug. ***
Bumping version to a stable release.
*** Bug 640616 has been marked as a duplicate of this bug. ***
*** Bug 240294 has been marked as a duplicate of this bug. ***
*** Bug 592142 has been marked as a duplicate of this bug. ***
what is status of this bug/request? It would come very handy and I cannot imagine it being that hard to implement to be taking more than 10 years from initial report.. I realize that all you developers are very busy, but can somebody finally take a look at this issue? :)
Created attachment 296150 [details] [review] Proposed patch Here is a proposed patch for this bug. The diff is from tag EVOLUTION_3_12_7 with hash f9ed2592704641c265568e91bf2c31ccd49433b2, but it should be alright on the latest trunk too, though I only tested it on 3.12.7.
Review of attachment 296150 [details] [review]: Thanks for the patch. It looks pretty neat and small and applies to current git master flawlessly. Please see my notes below. I noticed an issue with packing, the new entries are not packed at the same vertical position as the combobox is, which makes it look weird. Further more, I would not touch e_mail_identity_combo_box_refresh() at all, let's keep it as is and provide the on-demand customizable name/email at a new line, just below the From combo box. This part should be either as an expander-like widget, or a new item in the View menu (the later will make it easier to open the composer with it expanded/collapsed based on the state when the composer was closed the last time). Apart of that the entries could have its labels too, as there will be more place. I noticed one glitch when testing this. If I change for example name, save the message as Draft (which shows the changed name in the From header in the message preview), then reopening the Draft message doesn't read the saved name/email customization and picks the one from the selected From account instead. Finally, the customized name/email should not be used when the widgets are hidden. (It'll be relevant only after the proposed changes above.) ::: composer/e-composer-from-header.c @@ +61,3 @@ + name = gtk_entry_new (); + gtk_grid_attach (GTK_GRID (grid), g_object_ref_sink (name), 1, 0, 1, 1); + gtk_entry_set_text (GTK_ENTRY (name), "name"); Either set there an empty string or localize this one @@ +65,3 @@ + address = gtk_entry_new (); + gtk_grid_attach (GTK_GRID (grid), g_object_ref_sink (address), 2, 0, 1, 1); + gtk_entry_set_text (GTK_ENTRY (address), "address"); similar with 'name' above @@ +195,3 @@ + GtkEntry *widget; + + g_return_val_if_fail (E_IS_COMPOSER_FROM_HEADER (header), NULL); compiler warning: returning NULL from a 'void' function (similar with 'address' function below) @@ +198,3 @@ + + if (!name) + return; I thing it might be treated as an empty string @@ +233,3 @@ + + if (!address) + return; Similar to 'name' above ::: composer/e-composer-from-header.h @@ +66,3 @@ +const gchar * e_composer_from_header_get_name + (EComposerFromHeader *header); +void e_composer_from_header_set_name coding style: one more tab after 'void' (similar for 'address' below)
I updated Valentin's patch for things mentioned in the previous comment and pushed it to sources with credits to Valentin, because my changes were only about added buzz around UI option to show/hide the widgets, which is the boring part of this bug report: Created commit 4d7188d in evo master (3.15.91+)
I didn't have time to implement the changes recently, but I totally agree with your comments and your commit. Thanks a lot!
(In reply to gnome-devel from comment #13) > I didn't have time to implement the changes recently, but I totally agree > with your comments and your commit. Thanks a lot! No problem, I thank you for starting this change. Mine follow-up changes were rather minor, as I also said above.