Bug 209254 – Composer misses "Help" button in menu

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 209254 - Composer misses "Help" button in menu


Summary:	Composer misses "Help" button in menu


Status:	RESOLVED FIXED

Product:	evolution
Classification:	Applications
Component:	Mailer
Version:	2.8.x (obsolete)
Hardware:	Other All

Importance:	High critical
Target Milestone:	Future
Assigned To:	evolution-mail-maintainers
QA Contact:	Evolution QA team

URL:
Whiteboard:	evolution[composer]

Depends on:
Blocks:

Reported:	2001-09-08 10:18 UTC by Kasper Ligaard Nielsen
Modified:	2013-09-13 00:50 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
added a help menu item for the compose new message window (4.35 KB, patch) 2006-07-14 05:49 UTC, arvind	committed	Details \| Review

Description Kasper Ligaard Nielsen 2001-09-08 10:21:01 UTC

Package: Evolution
Priority: Wishlist
Version: 0.13.99
Synopsis: "New Message" dialog needs "Help" button in menu
Bugzilla-Product: Evolution
Bugzilla-Component: Mailer

Description:
I was tinkering with the possibilities of layout in the "New Message"
dialog. Instead of just playing with it I suddenly wanted to read about
my possibilities. Then I had to realise that there is no way of getting
help from within the "New Message" dialog.

My suggestion for a solution would be twofold:
1) Add the button right away. Just let it open the general evolution
mail help.
2) When there the helptext specific to the "New Message" dialog is
ready, let the help button link to that (so that it's more context
sensitive).



Unknown reporter: ligaard@trillegaarden.dk, changed to bugbuddy-import@ximian.com.

Comment 1 Jeffrey Stedfast 2001-11-20 19:06:41 UTC

feature = future

Comment 2 Luis Villa 2001-12-12 16:33:54 UTC

Anna, is this something you'd like to see as a 1.2 UI tweak?

Comment 3 Anna Marie Dirks 2001-12-12 18:09:26 UTC

Hrm. I agree with the submitter that this would be a useful feature. 
(Well, not a help button per se, but a help menu item.) Of course,
adding a help item to the composer would necessitate adding help items
to the appointment editor, the task editor, and the contact manager as
well.  

Since the "Help" menu persists as one of the top level menus in each
component, (that is, it is already quite simple to get help for
creating a new message/appointment/etc) I am inclined to think that
this bug should remain "future". We already have too many things that
we are committed to doing for 1.2, and this just isn't terribly crucial.

Comment 4 Jeffrey Stedfast 2002-01-22 18:51:09 UTC

marking as future?

Comment 5 Calum Benson 2005-07-28 10:40:09 UTC

Apologies for any spam... cc'ing usability-maint on all Evolution usability
bugs. Filter on EVO-USABILITY-SPAM to ignore.

Comment 6 arvind 2006-07-14 05:49:05 UTC

Created attachment 68900 [details] [review]
added a help menu item for the compose new message window

Comment 7 Srinivasa Ragavan 2006-07-14 06:55:53 UTC

Fixed to head. Please send a mail to gnome-i18n and gnome-doc-list about the changes.

Comment 8 André Klapper 2006-07-14 22:13:28 UTC

evolution 2.7.4 cvs head crashed when i tried to write an email to srini. so it must be srini's fault - kind of. ;-)

if you take a look at my stacktrace, thread #1:

+ Trace 69339

Thread 1 (Thread -1236646224 (LWP 20700))

#0 __kernel_vsyscall
#1 __lll_mutex_lock_wait
from /lib/libc.so.6
#2 _L_mutex_lock_113
from /lib/libc.so.6
#3 ??
#4 ptmalloc_lock_all
from /lib/libc.so.6
#5 fork
from /lib/libc.so.6
#6 fork
from /lib/libpthread.so.0
#7 libgnomeui_segv_handle
at gnome-ui-init.c line 844
#8 <signal handler called>
#9 __kernel_vsyscall
#10 raise
from /lib/libc.so.6
#11 abort
from /lib/libc.so.6
#12 __libc_message
from /lib/libc.so.6
#13 malloc_printerr
from /lib/libc.so.6
#14 free
from /lib/libc.so.6
#15 IA__g_free
at gmem.c line 187
#16 destroy
at e-msg-composer.c line 2768
#17 IA__g_cclosure_marshal_VOID__VOID
at gmarshal.c line 77
#18 g_type_class_meta_marshal
at gclosure.c line 567
#19 IA__g_closure_invoke
at gclosure.c line 490
#20 signal_emit_unlocked_R
at gsignal.c line 2554
#21 IA__g_signal_emit_valist
at gsignal.c line 2197
#22 IA__g_signal_emit
at gsignal.c line 2241
#23 gtk_object_dispose
at gtkobject.c line 418
#24 gtk_widget_dispose
at gtkwidget.c line 6873
#25 gtk_window_dispose
at gtkwindow.c line 1794
#26 bonobo_window_dispose
at bonobo-window.c line 143
#27 composer_dispose
at e-msg-composer.c line 2747
#28 IA__g_object_unref
at gobject.c line 1734
#29 composer_send_queued_cb
at em-composer-utils.c line 241
#30 append_mail_appended
at mail-ops.c line 880
#31 mail_msgport_replied
at mail-mt.c line 461
#32 g_io_unix_dispatch
at giounix.c line 162
#33 g_main_dispatch
at gmain.c line 2043
#34 IA__g_main_context_dispatch
at gmain.c line 2594
#35 g_main_context_iterate
at gmain.c line 2675
#36 IA__g_main_loop_run
at gmain.c line 2879
#37 bonobo_main
at bonobo-main.c line 311
#38 main
at main.c line 614
#0 __kernel_vsyscall

Comment 9 Srinivasa Ragavan 2006-07-17 11:20:59 UTC

Fixed to HEAD.

Comment 10 Hiroyuki Ikezoe 2006-07-18 08:05:27 UTC

srini, your fix causes memory leak.

you should check that p->help_section is NULL like the following:

if (p->help_section) {
        g_free (p->help_section);
        p->help_section = NULL;
}

Or, the fourth argument of gnome_help_display_desktop() accepts const char, so you can use a string directly like this:

gnome_help_display_desktop (NULL,
                            "evolution-" BASE_VERSION,
                            "evolution-" BASE_VERSION ".xml",
                            "usage-composer",
                             &error);

Comment 11 André Klapper 2006-07-18 09:02:17 UTC

reopening as per last comment.

Comment 12 Srinivasa Ragavan 2006-07-18 09:20:17 UTC

Thanks HERO. I have used constant string now. Fixed to HEAD.