GNOME Bugzilla – Bug 205616
UI: Filter dialog needs top/bottom buttons
Last modified: 2013-09-10 14:04:09 UTC
The filter dialog really, really needs top and bottom buttons for moving filters. When you have more than a hundred filters (lots of lists) like I do, and you want to filter lists first, and then people, for instance, and new filters are always added to the bottom of the list, adding a new mailing list filter involves more than a hundred mouse clicks. My hand was extremely tired the first time I set up Evolution to handle all my lists.
*** bug 223465 has been marked as a duplicate of this bug. ***
related to DnD re-ordering, see bug 200975.
adding filters keyword
*** Bug 312774 has been marked as a duplicate of this bug. ***
Created attachment 50339 [details] [review] Filter patch to add top/bottom targets Considering how old this bug is I thought i'd have a go myself. 15 minutes later (and an hour or so to compile and test with evo) we have a test implementation. One note, there is definitely a better way to implement the list count of the filter view (ie. use g_list_length or similar) but I haven't deconstructed how the RuleEditor view works so I just used a similar count routine used elsewhere in filter/rule-editor.c. One easy way I can think of doing this is to add an 'int count' to the RuleEditor struct and re-count the list on initialisation/add/delete, etc.
targetting this to 2.5 to force a decision. matthew: thanks for the patch, if you ever plan to write another patch for evolution, please submit it in form of a unified diff (cvs diff -u -p), therefore setting patch status to "needs-work". thanks in advance. ;-)
Created attachment 52610 [details] [review] filter manager patch to add top/buttom buttons i took matthew's patch and put it into the correct format. this is untested from my side; hopefully it's also okay for matthew if i put him and his mail address into the changelog? matthew, a short "OK" would be great... :-)
Yep, this is fine with me. Thanks andre.
Hmm one issue. Try moving a rule from top to bottom using bottom its not working. It works otherwise. A minor bug with the code.
changed the status of the patch to needs-rework based on the last comment
Created attachment 52702 [details] [review] top/bottom filter target Fixed the bottom filter target bug. As simple as the difference between '>' and '>=' (Doh!) Thanks, Matt.
man, this is workflow. cool. also thanks. srag, let's get this into 2.5's HEAD. :-)
Looks fine now. Andre, Matt, Thanks for the patch
ok, this is not workflow. sigh... HELLO?! PLEASE COMMIT. thanks. adding partha to CC.
was pissed by waiting for this, so talked to srag on #evolution irc channel today and he said "go ahead and commit to CVS". matthew, i just committed this to HEAD so it will be included in evolution 2.5.4 and the upcoming stable 2.6: http://cvs.gnome.org/viewcvs/evolution/filter/filter.glade?r1=1.24&r2=1.25 http://cvs.gnome.org/viewcvs/evolution/filter/rule-editor.c?r1=1.65&r2=1.66 a big personal thanks for the code since i was annoyed by those missing buttons all those years. ...and now: champagne! :-)
Sweet. Thanks for pushing this Andre. Merry Xmas :)
hehe. yeah, i partially have become "bugging master" (veerapuram invented that term). ;-) merry christmas also to you, matthew, and have a nice new year. :-)