GNOME Bugzilla – Bug 172766
The key bindings associated with the scrolling operation should be user configurable
Last modified: 2007-11-28 13:10:22 UTC
Currently, gnome-terminal uses <Shift>Page Up, <Shift>Page Down, <Shift>Home and <Shift>End keys to scroll up/down. It would be nice if these keys be made configurable. This would help people who wish to scroll up/down using only the PageUp/PageDown/Home/End keys (without having to use the Shift key). One of the approaches to achieve the above is: 1. Add new gconf keys. -> apps/gnome-terminal/keybindings/scroll_page_up -> apps/gnome-terminal/keybindings/scroll_page_down -> apps/gnome-terminal/keybindings/scroll_home -> apps/gnome-terminal/keybindings/scroll_end 2. In the 'Edit->Keyboard Shortcuts' dialog, include the following under the 'Go' action. (See attached screenshot terminal1.png) -> Scroll One Page Up -> Scroll One Page Down -> Scroll to First Line -> Scroll to Last Line 3. In the 'View' menu, add Scroll Page Up, Scroll Page Down, Scroll Home, Scroll End menuitems (See attached screenshot terminal2.png) I'm attaching terminal and vte patches for the same. Please let know if the approach is fine or is there any other way that the problem can be fixed.
Created attachment 39732 [details] Screenshot of the keyboard shortcuts dialog.
Created attachment 39733 [details] Screenshot of the view menu.
Created attachment 39734 [details] [review] Proposed patch for gnome-terminal
Created attachment 39735 [details] [review] Proposed patch for vte
Havoc, kindly give your comments on the above approach.
I noted in email that I would change vte over to use GtkBindingSet and then people can immediately configure this from .gtkrc-2.0 Then figure out how to do a GUI editor around that. But these patches are wrong, you don't want to break VTE's keybindings, and you definitely don't want these View menu items.
Created attachment 45824 [details] [review] Modified patch to make use of GtkBindingSet
Created attachment 46865 [details] [review] modifying the patch to use g_signal_new instead of _gtk_binding_signal_new havoc: patched based on your comments, okay to commit? please let know if any modifications need to be done.
havoc: ping :)
--> vte
Apologies for spam... ensuring Sun a11y folks are cc'ed on all current accessibility bugs.
Apologies for spam... marking as AP4 to reflect accessibility impact.
I like this, and the patch looks sane. We should fold into this the scroll back/down one line patch from bug 118967.
Ping? We still get regular complaints about PgUp/PgDn/Home/End being "broken" in gnome-terminal on [Open]Solaris.
I intend to look at the key bindings issues once gnome-2.18 is out of the way.
Shouldn't we use GtkBindings as Chris suggested in bug 399057? Please reopen if not. *** This bug has been marked as a duplicate of 399057 ***