After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 171301 - add more stock icons so you use less memory and programs look more alike (better HIG)
add more stock icons so you use less memory and programs look more alike (bet...
Status: RESOLVED WONTFIX
Product: gtk+
Classification: Platform
Component: [obsolete] stock-icons
unspecified
Other All
: Normal normal
: Small API
Assigned To: gtk-bugs
gtk-bugs
: 171300 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-03-23 00:57 UTC by Kristof Vansant
Modified: 2013-08-14 01:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add bookmark stock item (1.89 KB, patch)
2006-05-25 19:44 UTC, Kristof Vansant
none Details | Review
gtk bookmark stock item (1.26 KB, patch)
2006-05-25 19:47 UTC, Kristof Vansant
rejected Details | Review
gtk-bookmarks.png (1.26 KB, image/png)
2006-05-25 19:49 UTC, Kristof Vansant
  Details

Description Kristof Vansant 2005-03-23 00:57:37 UTC
Please describe the problem:
these icon could be used by a lot of apps since the user icon could also be used
to repesent an account.

I think this could be used by gdm, user config apps, evolution, gaim, etc

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 2 Rob Staudinger 2005-07-22 09:39:15 UTC
From the POV of an AbiWord developer it would be good if we had stock icons for
- Bullet List
- Numbered List
these are very likely useful to applications that also use the existing font
B/I/U and align left/right/center/justify stock icons.
Comment 4 Kristof Vansant 2005-07-22 13:06:04 UTC
Contacts

TODO/Tasks

Calendar

Mail
http://cvs.gnome.org/viewcvs/libgnomeui/libgnomeui/pixmaps/stock_mail.png?rev=1.2&view=markup

can't find them in the evolution cvs. Does anyone know where I can find them.
Comment 5 Kristof Vansant 2005-07-27 11:42:24 UTC
when looking at gaim I noticed these that I think could be interresting for
other apps too:
#define GAIM_STOCK_BGCOLOR         "gaim-bgcolor"
#define GAIM_STOCK_FGCOLOR         "gaim-fgcolor"
#define GAIM_STOCK_TEXT_BIGGER     "gaim-text-bigger"
#define GAIM_STOCK_TEXT_NORMAL     "gaim-text-normal"
#define GAIM_STOCK_TEXT_SMALLER    "gaim-text-smaller"
Comment 6 Kristof Vansant 2005-07-27 11:43:56 UTC
*** Bug 171300 has been marked as a duplicate of this bug. ***
Comment 7 Christian Neumair 2005-08-22 21:57:06 UTC
Also note that translators are tired of translating basic vocabulary like
"_File", "_Edit", "View, "_Go To", "_Undo" and "_Redo". These could easily be
added to GTK+ as GtkStockItems.
Comment 8 Kristof Vansant 2005-08-22 22:15:54 UTC
I guess these are the most importent one's:
http://developer.gnome.org/projects/gup/hig/2.0/menus-standard.html

we should stick to the HIG in my opinion
Comment 9 Kristof Vansant 2006-05-25 19:44:08 UTC
Created attachment 66219 [details] [review]
add bookmark stock item
Comment 10 Kristof Vansant 2006-05-25 19:47:24 UTC
Created attachment 66220 [details] [review]
gtk bookmark stock item

place icon in /gtk+/gtk/stock-icons/24/

icon comes from http://cvs.gnome.org/viewcvs/epiphany/data/art/epiphany-bookmarks.png?rev=1.2&view=markup

I haven't asked premission from creator icon is this a problem?
Comment 11 Kristof Vansant 2006-05-25 19:49:39 UTC
Created attachment 66221 [details]
gtk-bookmarks.png
Comment 12 Kristof Vansant 2006-05-25 19:51:08 UTC
if this patch gets accepted I'll do the same for the other icons
Comment 13 Matthias Clasen 2006-05-26 12:46:59 UTC
There may be other arguments for adding stock items, but at least the
"icon memory saving" argument should not be an issue anymore. With
icon caching, themed icons should not use more memory than stock icons,
and it is shared between apps, too.
Comment 14 Philip Withnall 2007-05-26 16:24:35 UTC
Patch 66219 applies cleanly. Reviewing it would take little time.

(Working on http://mail.gnome.org/archives/gtk-devel-list/2007-March/msg00148.html)
Comment 15 Diego Escalante Urrelo (not reading bugmail) 2008-04-16 06:46:57 UTC
There are new icons in epiphany for bookmarks.

The original intention of adding more stock icons is still valid though. Patch seems ok.

http://live.gnome.org/GtkLove/PatchTriaging spam.
Comment 16 Matthias Clasen 2013-08-14 01:50:06 UTC
gtk stock apis have been deprecated