After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 171179 - Undo for location entry
Undo for location entry
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Controls
unspecified
Other Linux
: Normal minor
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
fixed1.8
: 128662 (view as bug list)
Depends on: 322194 351571
Blocks:
 
 
Reported: 2005-03-22 07:35 UTC by Matthew Paul Thomas (mpt)
Modified: 2008-02-15 01:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed fix (1.59 KB, patch)
2005-03-22 08:42 UTC, Christian Persch 		committed Details | Review
patch (10.34 KB, patch)
2008-02-06 15:51 UTC, Cosimo Cecchi 		committed Details | Review

Description Matthew Paul Thomas (mpt) 2005-03-22 07:35:43 UTC 
Distribution/Version: Ubuntu Hoary preview

Steps to reproduce:
1.  Type some stuff in the address field.
2.  Press Escape.

What should happen:
*   The contents of the field reverts to the URL of the current page.

What actually happens:
*   Nothing.
Comment 1 Christian Persch 2005-03-22 08:29:31 UTC 
*** Bug 128662 has been marked as a duplicate of this bug. ***
Comment 2 Christian Persch 2005-03-22 08:42:14 UTC 
Created attachment 39058 [details] [review]
proposed fix

Should there also be an entry in the context menu for this?
Comment 3 Matthew Paul Thomas (mpt) 2005-03-22 09:58:37 UTC 
I think "Edit" > "Undo" when the address field is focused should also revert the
URL, and that "Undo" should be the first item in the shortcut menu for any text
field.
Comment 4 Christian Persch 2005-04-10 19:31:40 UTC 
I committed the patch to cvs. Leaving open for the remaining issue (context menu).
Comment 5 Christian Persch 2005-04-10 19:37:40 UTC 
Oops
Comment 6 Cyril Brulebois 2007-09-07 04:55:21 UTC 
Christian: Want me to implement the context menu part?
Comment 7 Christian Persch 2007-09-07 22:28:16 UTC 
If you want, sure :)
Comment 8 Cosimo Cecchi 2008-02-06 15:51:47 UTC 
Created attachment 104567 [details] [review]
patch

This attached patch adds Undo and Redo commands for EphyLocationEntry, adds them to the context menu in the first two position as suggested, and links them to Edit->Undo/Redo in the main window.
Comment 9 Cosimo Cecchi 2008-02-15 01:12:17 UTC 
Committed, closing as FIXED.

------------------------------------------------------------------------
r7945 | cosimoc | 2008-02-15 02:10:36 +0100 (ven, 15 feb 2008) | 3 lines

Add Undo/Redo commands to the location entry, both in the context menu
and linked to the main window commands. Bug #171179.