After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 170921 - fails to function with 2.4 kernel
fails to function with 2.4 kernel
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: multiload
2.10.x
Other Linux
: Normal major
: 2.10
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
: 300644 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-03-19 18:23 UTC by Tommi Komulainen
Modified: 2005-04-14 19:24 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
proposed patch (689 bytes, patch)
2005-03-19 18:26 UTC, Tommi Komulainen 		accepted-commit_now Details | Review

Description Tommi Komulainen 2005-03-19 18:23:53 UTC 
Multiload applet fails to show any processor activity with 2.4 kernel.  Apparently
GLIBTOP_CPU_IOWAIT isn't available, making the following assertion in
linux-proc.c fail:

    g_return_if_fail ((cpu.flags & needed_cpu_flags) == needed_cpu_flags);
Comment 1 Tommi Komulainen 2005-03-19 18:26:14 UTC 
Created attachment 38941 [details] [review]
proposed patch

Remove iowait from mandatory flags.  If iowait value is missing, initialize it
to known value (zero)
Comment 2 Tommi Komulainen 2005-03-19 18:42:30 UTC 
loadavg also fails to show anything useful.  While top shows loadavg of 80% or
so, the applet shows 0% .. when top shows > 100%, the applet shows 8%
Comment 3 Tommi Komulainen 2005-03-19 18:58:17 UTC 
Debugging loadavg little further it seems that there's only two different values
being given, 0.00 and 1.00 :-/
Comment 4 Danielle Madeley 2005-03-20 04:20:53 UTC 
(hmm, bugzilla has changed a bit, let's see what this does)

This patch looks great. G-A hasn't branched yet, but it can be committed to HEAD.
Comment 5 Danielle Madeley 2005-03-20 14:41:11 UTC 
2005-03-20  Davyd Madeley  <davyd@madeley.id.au>

        * linux-proc.c: Make the CPU graph work on Linux 2.4 again. Closes
        #170921. Patch by Tommi Komulainen <tommi.komulainen@iki.fi>.
Comment 6 Benoît Dejean 2005-04-14 19:24:12 UTC 
*** Bug 300644 has been marked as a duplicate of this bug. ***