Created attachment 38928 [details] [review]
use GtkAboutDialog instead of GnomeDialog

use GtkAboutDialog, may you take a look at the patch, please?

After a quick look at svn this is still valid.

Can some confirm if the bug is fixed in CVS or latest release 2.22? If not, then we should push it to action asap prior to 2.24.

Still not committed. src/netstatus-applet.c contains:

#include <libgnomeui/gnome-about.h>

I imagine that this is also probably the root cause of this Ubuntu bug. Even if not, it should be fixed while resolving this bug. No reason to take time fixing code that is deprecated and should be changed anyway.

Please see: https://bugs.edge.launchpad.net/ubuntu/+source/gnome-netstatus/+bug/289649



Binary package hint: gnome-netstatus-applet

When opening the applet's about page by right clicking the icon and choosing about, the box doesn't close when pressing the "close" button. Credits page unaffected by this.

Expected behaviour would be for the about box to close, nothing happens. The "x" for closing the window works as intended.

Version of the applet, as reported by the about page itself: gnome-netstatus-applet 2.12.2
Ubuntu version tested on: Ubuntu 64bit 8.10 Intrepid

sami@sami-desktop:~$ lsb_release -rd
Description: Ubuntu 8.10
Release: 8.10
sami@sami-desktop:~$ apt-cache policy gnome-netstatus-applet
gnome-netstatus-applet:
  Installed: 2.12.2-0ubuntu1
  Candidate: 2.12.2-0ubuntu1
  Version table:
 *** 2.12.2-0ubuntu1 0
        500 http://archive.ubuntu.com intrepid/main Packages
        100 /var/lib/dpkg/status

Fixed in trunk with a different patch (wish I had seen this one before!).