After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 168549 - glib2 functions should be used for XDG_DATA_* stuff
glib2 functions should be used for XDG_DATA_* stuff
Status: RESOLVED FIXED
Product: gnome-vfs
Classification: Deprecated
Component: MIME and file/program mapping
cvs (head)
Other All
: High enhancement
: ---
Assigned To: gnome-vfs maintainers
gnome-vfs maintainers
Depends on:
Blocks:
 
 
Reported: 2005-02-25 21:18 UTC by Jens Elkner
Modified: 2005-08-24 04:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (against HEAD). (1.67 KB, patch)
2005-05-01 20:04 UTC, Christian Neumair 		committed Details | Review

Description Jens Elkner 2005-02-25 21:18:00 UTC 
Version details: 2.9.91

For consistency reasons, gnome-vfs-2.9.91/libgnomevfs/xdgmime.c:gnome_vfs_mime_init
 as well as
gnome-vfs-2.9.91/libgnomevfs/gnome-vfs-mime-info.c:xdg_run_command_on_dirs 
 should use the glib2 functions to determine required directories instead of
"re-implementing" the search path construction.

E.g. as in gtk+-2.6.1/gtk/gtkicontheme.c:gtk_icon_theme_init
Comment 1 Christian Neumair 2005-04-30 20:38:44 UTC 
Thanks for your bug report. You're totally right.
Comment 2 Christian Neumair 2005-05-01 19:59:50 UTC 
I've filed an individual bug report against xdgmime [1].

[1] https://bugs.freedesktop.org/show_bug.cgi?id=3172
Comment 3 Christian Neumair 2005-05-01 20:04:34 UTC 
Created attachment 45917 [details] [review]
Proposed patch (against HEAD).

Should fix the gnome-vfs part.
Comment 4 Christian Neumair 2005-05-01 20:30:51 UTC 
xdgmime is plain C, no chance to have it fixed.
Comment 5 Christophe Fergeau 2005-06-24 21:28:50 UTC 
This patch looks fine to me, I hope it still applies.
Comment 6 Christian Kellner 2005-08-24 04:19:19 UTC 
Commited on head.