After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 167471 - Critical warning when switching to fullscreen
Critical warning when switching to fullscreen
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: image viewer
git master
Other All
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-02-15 14:46 UTC by Paolo Borelli
Modified: 2005-07-27 15:59 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10



Description Paolo Borelli 2005-02-15 14:46:29 UTC
Please describe the problem:
When switching to fullscreen with F11 the following warning is printed

(eog:30881): Gdk-CRITICAL **: gdk_window_get_origin: assertion `window != NULL'
failed


from a cursory look the warning is triggered by

	monitor = gdk_screen_get_monitor_at_window (screen, GTK_WIDGET (fs)->window);

in eog-full-screen.c::eog_full_screen_instance_init

and is pretty reasonable since fs has just been created and never realized so
->window is still null.



Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Kjartan Maraas 2005-06-22 19:38:42 UTC
I see this too.
Comment 2 Paolo Borelli 2005-06-25 19:51:27 UTC
took another quick look at this...

just for reference, the problem was introduced when fixing this bug
http://bugzilla.gnome.org/show_bug.cgi?id=137137

my take is the following: as said above the warning is triggered because
GTK_WIDGET (fs)->window is NULL, since fs is not realized; this also explains
the problem still remaining in bug #137137 (using always the first physical
monitor, no matter where eog is), since gdk_screen_get_monitor_at_window returns
the default.

My suggested solution is to fetch the monitor of the non maximized eog window
and pass it down to the eog_fullscreen_new() function, so that the right monitor
is used.

(no patchy patch, because I don't have a xinerama setup to test with)
Comment 3 Danielle Madeley 2005-07-24 09:55:58 UTC
There is a patch in bug #309100
Comment 4 Paolo Borelli 2005-07-27 15:59:51 UTC
this's been fixed by davyd's patch.