After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 167383 - Cannot create GtkArrow
Cannot create GtkArrow
Status: RESOLVED FIXED
Product: Gazpacho
Classification: Deprecated
Component: widget support
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Gazpacho Maintainer(s)
Gazpacho Maintainer(s)
Depends on: 161177
Blocks:
 
 
Reported: 2005-02-14 19:49 UTC by Johan (not receiving bugmail) Dahlin
Modified: 2005-07-18 22:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Maybe a working patch (4.32 KB, patch)
2005-03-31 23:48 UTC, Mattias Karlsson
none Details | Review
Updated patch (4.26 KB, patch)
2005-04-02 10:14 UTC, Mattias Karlsson
none Details | Review
patch against pygtk-2.6.2 that allows gazpacho to create arrows (389 bytes, patch)
2005-06-03 01:20 UTC, Tim Evans
none Details | Review

Description Johan (not receiving bugmail) Dahlin 2005-02-14 19:49:33 UTC
Traceback (most recent call last):
  • File "/home/jdahlin/dev/sicem/gazpacho/gazpacho/placeholder.py", line 117 in do_button_press_event
    None)
  • File "/home/jdahlin/dev/sicem/gazpacho/gazpacho/command.py", line 84 in create
    widget = Widget(klass, project, interactive=interactive)
  • File "/home/jdahlin/dev/sicem/gazpacho/gazpacho/widget.py", line 148 in __init__
    widget = klass.type()
TypeError: gtk.Arrow.__init__() takes exactly 2 arguments (0 given)

Comment 1 Mattias Karlsson 2005-03-31 23:48:43 UTC
Created attachment 39532 [details] [review]
Maybe a working patch

I've been playing around with the code to see if I could understand how it
works and I came up with the following patch in the meantime. It seems quite
nice but I don't really know this part of the code and maybe it's totaly wrong.
:)

This patch solves Bug 167379 and Bug 167380 as well.
Comment 2 Mattias Karlsson 2005-03-31 23:50:40 UTC
Oh, I forgot to mention. It's still not possible to copy the Fond and Color
dialogs. Might be the same bug that used to affect the normal dialog?
Comment 3 Mattias Karlsson 2005-04-02 10:14:10 UTC
Created attachment 39589 [details] [review]
Updated patch

I've updated the patch against the latest version from SVN. There are still
some problems though. The widgets can't be loaded from glade files or copied. I
guess there has to be some modifications made to gazpacho/loader/widgettree.py
for this to work?
Comment 4 Lorenzo Gil Sanchez 2005-04-06 20:16:51 UTC
The proper way of solving this is fixing the bug in pygtk that is blocking us
from creating the widgets with gobject.new.

For the Arrow, we can fix the problem with your patch and also patching
widgetree.py but we still need to do that for every widget that need constructor
parameters. Even worse, we need to call this code whenever we instantiate one of
this widgets (paste, undo delete, ..)

As I said let's fix gobject.new in pygtk first.
Comment 5 Mattias Karlsson 2005-04-06 20:58:14 UTC
I guess this pygtk bug wont be fixed before a 0.5.3 release? If that is the
case, should we remove it as a blocker for Bug 172261? If it isn't fixed for the
next release, maybe we should disable this object in the palette at least.
Comment 6 Lorenzo Gil Sanchez 2005-04-06 21:19:14 UTC
I'm disabling them from the palette and yes, we should remove them from the
blocking list
Comment 7 Tim Evans 2005-06-03 01:20:09 UTC
Created attachment 47172 [details] [review]
patch against pygtk-2.6.2 that allows gazpacho to create arrows

The attached changes pygtk so that he arguments to gtk.Arrow() are optional.  I
know that this should really be filed against pygtk, but I'm not sure if it
should be attached to Bug #161177 or filed as a separate bug.  Decided to let
someone here work that out.
Comment 8 Johan (not receiving bugmail) Dahlin 2005-07-18 22:03:38 UTC
Fixed this in an alternative way.