After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 167344 - singular and plural form of "Open in New Window" is invalid(?)
singular and plural form of "Open in New Window" is invalid(?)
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Internationalization (i18n)
2.10.x
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 168068 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-02-14 13:07 UTC by Young-Ho Cha
Modified: 2005-05-21 14:25 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
Avoid msgid conflict around ngettext() (1.57 KB, patch)
2005-02-17 18:43 UTC, Changwoo Ryu 		none Details | Review

Description Young-Ho Cha 2005-02-14 13:07:20 UTC 
Please describe the problem:
in chinese, korean, and japanese "Open in New Window" & "Open in %d New Windows"
translate incorrectly.

it seems invalid usage of gettext.

see http://ftp.mizi.com/~ganadist/nau1.png

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?
yes

Other information:
Comment 1 Changwoo Ryu 2005-02-15 13:24:21 UTC 
More description:

The problem is, nautilus is using the same msgid in c-format string and
non-c-format ones.  This conflict was possible because the singular form had no
format specifier.  ("Open in New Window")

But in some langauges there's no distinction between singular/plural ones in
general, so their translations always contain the format specifier (%d).  When
the translated strings are used in non-c-format case, the format specifier will
be displayed as-is, like the above screenshot.
Comment 2 Changwoo Ryu 2005-02-17 18:43:06 UTC 
Created attachment 37607 [details] [review]
Avoid msgid conflict around ngettext()

2005-02-18  Changwoo Ryu  <cwryu@debian.org>

	* src/file-manager/fm-directory-view.c (real_update_menus)
	(real_update_menus): Fixed a string conflict between the c-format
	plural string and non-c-format strings.  Bug #167344.

In the patch, "Open in %d New Window" string is not user-visible
(selection_count  is never 1), but is required to use ngettext().
Comment 3 Richard Hoelscher 2005-02-21 17:56:44 UTC 
*** Bug 168068 has been marked as a duplicate of this bug. ***
Comment 4 Martin Wehner 2005-05-10 21:22:25 UTC 
Comitted on HEAD, thank you.
Comment 5 Funda Wang 2005-05-10 21:42:52 UTC 
This is a critial i18n bug for the languages without plural forms, such as CJK. 
So, I would suggest committing it into gnome-2-10 branch, even it might 
introduce a string breakage.
Comment 6 Martin Wehner 2005-05-21 14:25:48 UTC 
I've requested a string freeze break to get this into the stable branch. Thanks
for the notice.