After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 166579 - Improvements to file and comment labels on Web Album creation
Improvements to file and comment labels on Web Album creation
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
2.6.x
Other All
: Normal enhancement
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on:
Blocks:
 
 
Reported: 2005-02-07 17:27 UTC by Duncan Thomson
Modified: 2011-07-02 12:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
same patch stored in bugzilla (17.12 KB, patch)
2005-02-20 10:11 UTC, Paolo Bacchilega
none Details | Review

Description Duncan Thomson 2005-02-07 17:27:24 UTC
Allow %f (for filename) and %c (for comment) information in header and foooter
lines in Web Album creation.

Also, when filename labels are added to thumbnail and image views, use the
original (source) filename, not the new (generated) file name, to avoid loss of
descriptive information that user may have captured in original file names.

Other information:
I have working code that implements the above changes.  (E-mail sent to Paolo on
this subject.)  I can clean up and submit patch if these changes are considered
useful.  Let me know at duncant@mitre.org or duncanhome@verizon.net.  Thanks.
Comment 1 Duncan Thomson 2005-02-20 01:48:47 UTC
I have fixed this bug.  Patches are available at:

http://duncant.is-a-geek.org:8080/patch.diff.txt

Any questions, please e-mail me.  I hope I created the patch in the right
format, please let me know if I need to do it differently.

Duncan Thomson
duncanhome@verizon.net
Comment 2 Paolo Bacchilega 2005-02-20 10:11:06 UTC
Created attachment 37703 [details] [review]
same patch stored in bugzilla

this is the same patch stored in bugzilla
Comment 3 Alan Horkan 2005-04-05 14:49:37 UTC
Adding patch keyword and marking as New.  marking severity as enhancment.  
Comment 4 Michael Chudobiak 2006-11-03 20:53:48 UTC
Duncan,

Can you supply an updated patch that will patch against CVS HEAD? I'll review it for inclusion. Your patch looks very useful.

- Mike
Comment 5 Rennie deGraaf 2006-11-06 05:29:53 UTC
Keep an eye on bug 319933 - it splits the comment output into separate sections for comment, place, and date.  If the fix for that bug gets accepted, then you'll probably want to add additional codes %p and %d for place and date.

Rennie
Comment 6 Paolo Bacchilega 2011-07-02 12:44:40 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.