After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 166202 - commands should be saved unexpanded
commands should be saved unexpanded
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: mini-commander
2.9.x
Other All
: Normal normal
: 2.10
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-02-03 19:39 UTC by Björn Torkelsson
Modified: 2005-02-04 08:40 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10


Attachments
Patch which saves the unexpanded command. (1.19 KB, patch)
2005-02-03 19:44 UTC, Björn Torkelsson
accepted-commit_now Details | Review

Description Björn Torkelsson 2005-02-03 19:39:30 UTC
Please describe the problem:
The history saves the expanded macros, i.e the commands actually run. It is
somewhat counter productive since the big win using macros is that you don't
have to remember the command. It also makes the autocompletion feature a lot
harder to use, since you have to know what the macro expands to.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Danielle Madeley 2005-02-03 19:41:54 UTC
This would be really nice to fix for GNOME 2.10.
Comment 2 Björn Torkelsson 2005-02-03 19:44:32 UTC
Created attachment 36940 [details] [review]
Patch which saves the unexpanded command.
Comment 3 Danielle Madeley 2005-02-04 08:05:33 UTC
Comment on attachment 36940 [details] [review]
Patch which saves the unexpanded command.

That looks pretty good. Do you have commit access?

If so, please commit to HEAD.
Comment 4 Danielle Madeley 2005-02-04 08:40:27 UTC
committed