After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 165811 - Spaces don't work in type-ahead find
Spaces don't work in type-ahead find
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
1.5.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
needs-forwarding
Depends on:
Blocks:
 
 
Reported: 2005-01-31 14:36 UTC by Sebastien Bacher
Modified: 2009-02-27 13:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gdb log (11.93 KB, text/plain)
2005-01-31 15:33 UTC, Christian Persch 		Details

Description Sebastien Bacher 2005-01-31 14:36:37 UTC 
This bug has been opened here: https://bugzilla.ubuntu.com/6013

"Note that this isn't just a highlighting problem, it's a problem with actually
finding strings with spaces in them in the first place. Eg:

1. Go to http://www.ubuntu.com/
2. Type /
3. Type "ubuntu linux"
4. Observe that although there are exact matches for "ubuntu linux" (which are
found correctly with the Ctrl+f find dialog), the highlighted text stays on the
first "ubuntu" match on the page, rather than finding "ubuntu linux" at all."
Comment 1 Christian Persch 2005-01-31 14:41:47 UTC 
Confirming.

It works in mozilla trunk (1.8b-ish) and its TestGtkEmbed, but not in Epiphany
compiled against it.

http://lxr.mozilla.org/seamonkey/source/extensions/typeaheadfind/src/nsTypeAheadFind.cpp
 
688   // ---------- PreventDefault check ---------------
689   // If a web page wants to use printable character keys,
690   // they have to use evt.preventDefault() after they get the key
691   nsCOMPtr<nsIDOMNSUIEvent> uiEvent(do_QueryInterface(aEvent));
692   PRBool preventDefault;
693   uiEvent->GetPreventDefault(&preventDefault);
694   if (preventDefault) {
695     return NS_OK;
696   }

Spaces don't pass this check, i.e. someone is calling PreventDefault() on those
keypresses. But Epiphany has no keypress handler (nor keydown)!
Comment 2 Christian Persch 2005-01-31 15:33:18 UTC 
Created attachment 36765 [details]
gdb log

+ Trace 55123

  • #0 nsDOMEvent::PreventDefault
    at nsDOMEvent.cpp line 377
  • #1 nsDOMKeyboardEvent::PreventDefault
    at nsDOMKeyboardEvent.h line 57
  • #2 nsXBLPrototypeHandler::ExecuteHandler
    at nsXBLPrototypeHandler.cpp line 348
  • #3 nsXBLWindowHandler::WalkHandlersInternal
    at nsXBLWindowHandler.cpp line 304
  • #4 nsXBLWindowKeyHandler::WalkHandlers
    at nsXBLWindowKeyHandler.cpp line 194
  • #5 nsXBLWindowKeyHandler::KeyPress
    at nsXBLWindowKeyHandler.cpp line 249
  • #6 DispatchToInterface
    at nsEventListenerManager.cpp line 136
  • #7 nsEventListenerManager::HandleEvent
    at nsEventListenerManager.cpp line 1602
  • #8 nsWindowRoot::HandleChromeEvent
    at nsWindowRoot.cpp line 226
  • #9 nsGlobalWindow::HandleDOMEvent
    at nsGlobalWindow.cpp line 922
  • #10 nsDocument::HandleDOMEvent
    at nsDocument.cpp line 3835
  • #11 nsGenericElement::HandleDOMEvent
    at nsGenericElement.cpp line 2026
  • #12 PresShell::HandleEventInternal
    at nsPresShell.cpp line 5942
  • #13 PresShell::HandleEvent
    at nsPresShell.cpp line 5774
  • #14 nsViewManager::HandleEvent
    at nsViewManager.cpp line 2375
  • #15 nsViewManager::DispatchEvent
    at nsViewManager.cpp line 2151
  • #16 HandleEvent
    at nsView.cpp line 171
  • #17 nsCommonWidget::DispatchEvent
    at nsCommonWidget.cpp line 218
  • #18 nsWindow::OnKeyPressEvent
    at nsWindow.cpp line 1638 

Here's the handler that's calling PreventDefault()
Comment 3 Christian Persch 2005-01-31 16:02:10 UTC 
Doesn't happen in galeon compiled against mozilla trunk.

Still happens without any epiphany extensions installed.
Comment 4 Christian Persch 2005-01-31 20:43:39 UTC 
This seems to be caused by the change from bug 141963: when epiphany starts with
accessibility.typeaheadfind.autostart set to 'true' typeaheadfind finds spaces;
when I set it to 'false' or if I start epiphany with it being 'false',
typeaheadfind doesn't find spaces.
Comment 5 Christian Persch 2005-02-01 20:32:17 UTC 
Fixed in cvs.

Someone should forward this bug to b.m.o.
Comment 6 Reinout van Schouwen 2005-02-21 16:17:31 UTC 
Is it possible to backport the fix to the 1.4 series?
Comment 7 Christian Persch 2005-02-21 18:37:19 UTC 
The patch from bug 141963 was never applied to gnome-2-8 branch, so this bug
shouldn't occur there.
Comment 8 Diego Escalante Urrelo (not reading bugmail) 2006-08-14 09:16:11 UTC 
This doesn't occur in Epiphany 2.14 (at least for me), would it be ok to close it?
Comment 9 Christian Persch 2006-08-14 10:58:05 UTC 
No, see comment 5.
Comment 10 Reinout van Schouwen 2007-04-28 00:45:14 UTC 
Christian, is a mozilla bug still needed? I will file one if that's all that's keeping this bug open.
Comment 11 Reinout van Schouwen 2007-05-17 22:03:01 UTC 
chpe, ping?
Comment 12 Christian Persch 2007-05-19 17:04:55 UTC 
The thing is that explaining what exactly the bug to file is about would require approx. the same energy as filing it myself :)
Comment 13 Xan Lopez 2009-02-27 13:00:28 UTC 
This works in Epiphany/WebKit. Closing.