After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 165760 - splash could make a better guess about text color
splash could make a better guess about text color
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: User Interface
git master
Other Linux
: Low enhancement
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2005-01-31 00:29 UTC by Carol
Modified: 2006-06-28 18:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Carol 2005-01-31 00:29:52 UTC 
currently the gimp averages the color of the lower 60 pixels of a splash image
to determine the color of the text.

a better guess would be made if it could average the area in the center of the
lower 60 pixels, which is where the text will be displayed.
Comment 1 Carol 2005-01-31 00:35:16 UTC 
s/pixels/rows/g
Comment 2 Sven Neumann 2005-01-31 13:45:35 UTC 
The text is not only displayed in the center, it may extend to the full width of
the splash screen. I don't think that it would make sense to use only the
center. What could be improved is the vertical position and size of the box that
is being averaged. It should not be hardcoded but could take the font height
into account.
 
This is of rather low priority though since the currently used algorithm works
reasonably well for almost all splash screens. The one that is in CVS is an
exception to this rule, but this splash won't be in any released version anyway.
Comment 3 Sven Neumann 2006-06-28 18:40:15 UTC 
The new code takes the actual text area (for an example text) into account instead of using a hardcoded region.

2006-06-28  Sven Neumann  <sven@gimp.org>

        * app/gui/splash.c: improved calculation of text color based on
        the splash image (bug #165760).