After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 164049 - [dvdec] NTSC framerate defined incorrectly
[dvdec] NTSC framerate defined incorrectly
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other All
: Low trivial
: NONE
Assigned To: Stephane Loeuillet
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-01-14 07:35 UTC by Jared Roberts
Modified: 2005-06-30 15:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Jared Roberts 2005-01-14 07:35:43 UTC 
gst-plugins/ext/dv/gstdvdec.c defines NTSC_FRAMERATE to be 29.997.  Unless I am
mistaken, this number should be 29.97 (there is one too many nines).

As an aside, many of these constants aren't DV specific.  Isn't there a better,
more common place for them to reside?
Comment 1 Stephane Loeuillet 2005-01-14 11:53:51 UTC 
it's true that the real value is 30000/1001 = 29.97002997

changing it in my local tree now, would commit it later today

thanks for spoting this

actually, it is defined here :
gst-plugins/ext/libfame/gstlibfame.c:        "framerate = (double) { 23.976024,
24.0, 25.0, 29.970030, 30.0, "
gst-plugins/ext/dv/gstdvdec.c:#define NTSC_FRAMERATE 29.997
gst-plugins/gst/y4m/gsty4mencode.c:    29.970, 30.000,             /* NTSC */

other numbers that are rounded differently :
23.976023999999999 = i don't know (25000/10001 gives 24,975024975)
59.940060000000003 = NTSC * 2 = 60000/1001
Comment 2 Stephane Loeuillet 2005-01-14 12:28:47 UTC 
fixed in gstreamer (core) and gst-plugins
the 23.97... thing is actuall 24000/1001 (it seems some video are around 24 fps
instead of usual 25/30 for PAL/NTSC)

closing, thanks
(and don't hesitate to reopen if i forgot to change some)
Comment 3 Ronald Bultje 2005-01-14 13:44:27 UTC 
It is not around 24. 24/1.001 is exact FILM framerate, which is used for NTSC
pull-down content.