After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 162582 - gcc4 compile warnings
gcc4 compile warnings
Status: VERIFIED FIXED
Product: GnuCash
Classification: Other
Component: General
git-master
Other Linux
: Normal normal
: ---
Assigned To: Chris Lyttle
Chris Lyttle
Depends on:
Blocks:
 
 
Reported: 2004-12-30 21:29 UTC by John Ellson
Modified: 2018-06-29 20:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix gcc4 warnings (76.40 KB, patch)
2004-12-30 21:36 UTC, John Ellson 		none Details | Review
gcc4 patches without the casts for char/gchar/xmlChar (13.03 KB, patch)
2004-12-31 18:08 UTC, John Ellson 		none Details | Review

Description John Ellson 2004-12-30 21:29:13 UTC 
gnucash CVS HEAD

export CC=/usr/bin/gcc4

./autogen.sh
make

- many gcc4 warnings - but compile dies because of -Werror

-- unitialized vars
-- sign mismatch between char, and xmlChar
-- signals should be guint instead of gint
Comment 1 John Ellson 2004-12-30 21:36:08 UTC 
Created attachment 35311 [details] [review]
fix gcc4 warnings
Comment 2 Derek Atkins 2004-12-30 22:30:22 UTC 
Hmm..  I'm always hesitant to add cast's to code, because an explicit cast can
many times hide/mask other bugs.
Comment 3 John Ellson 2004-12-31 18:08:37 UTC 
Created attachment 35325 [details] [review]
gcc4 patches without the casts for char/gchar/xmlChar
Comment 4 John Ellson 2004-12-31 18:12:30 UTC 
I've removed all the char casts from the patch.  The patch now
fixes some unitialized variables, some ignored const qualifiers on function
return values, and some gint -> guint mistypes.

I don't know about an specific flag in gcc4 to supress signed/unsinged mismatch
warnings.   I suggest just removing -Werror when compiling with gcc4.
Comment 5 Derek Atkins 2004-12-31 18:26:43 UTC 
This is much better.  I'm still concerned about removing the const-ness of the
GUID code.  Those returned objects should still be const.  If there are errors
associated with them it's due to how those functions are being used.  The uses
should be changed, rather than the source functions.
Comment 6 Derek Atkins 2004-12-31 18:37:35 UTC 
I've applied all of this latest patch to HEAD except the change to guid.[ch].

Thanks.

I'm closing this bug.  Please open a new one if you decide to change the GUID code.
Comment 7 John Ralls 2018-06-29 20:48:52 UTC 
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=162582. Please update any external references or bookmarks.