GNOME Bugzilla – Bug 162316
[PATCH] Playlist expander
Last modified: 2004-12-29 09:49:04 UTC
There was a suggestion to make the playlist expandable. Jorn said wouldn't look good but I did it and I think it looks fine. Of course, this means I also expanded the already massive PlaylistWindow.cs another 80 lines :-). Don't worry, I'll work on splitting it up soon... Anyway, apply this patch (it's against CVS as of 2004-12-26 and should work on 0.7.0) and tell me what you think. Oh, and while I was in there I made the playlist scrollbar have an automatic policy for both horizontal and vertical. I'm not sure why it wasn't like that already... Even if you don't like the expander, we should keep the automatic policy. Jorn said having a "Playlist" label in a small window looked weird but I don't think so. More and more apps are using expanders (Gimp dialogs look so much better now) so I think people will get used to having them around.
Created attachment 35221 [details] [review] Muine-CVS-20041226-PlaylistExpander.patch
Ooops, this is an enhancement... I'm leaving this open for comments.
I'm not going to commit this one I'm afraid. Here's why: I personally find it very confusing when windows resize themselves (having to "re-index" the UI in my head, takes half a second), as in by clicking a widget within the window- expanders are no exception for me. I don't really care what the HIG says at this point- I just hate them. In the new "Save as" dialog I can live with it, as there it really is only very extra functionality- whereas here it is about hiding the core of the app. Hmm. Hard to explain, to my mind there is a difference. Also, the previous/next buttons would be very odd with the playlist hidden. Don't tell me XMMS has a good UI. :) As for the scrollbar policy: The vertical scrollbar is set to be always shown to minimize the amount of widget resizing going on. As most of the time there will be more songs in the playlist than the widget can accomdate, there will be a scrollbar there most of the time- and to minimize resizing it has been set to an "always show" policy.
I wasn't planning on you committing it. I just threw it together because I had just done three code cleanup patches and it was like 2 am and I wanted something fun. I think we will have to agree to disagree about the automatic policy though.
Created attachment 35266 [details] [review] Muine-0.7.1-PlaylistExpander.patch Yo'av mentioned that Muine-CVS-20041226-PlaylistExpander.patch doesn't work with Muine 0.7.1 so here's a minor update change.