After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 162300 - [PATCH] SignalUtils
[PATCH] SignalUtils
Status: RESOLVED FIXED
Product: muine
Classification: Other
Component: general
trunk
Other Linux
: Normal normal
: ---
Assigned To: Muine Maintainers
Muine Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-12-27 08:06 UTC by Tamara Roberson
Modified: 2004-12-27 18:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Muine-CVS-20041226-SignalUtils.patch (11.31 KB, patch)
2004-12-27 08:07 UTC, Tamara Roberson
none Details | Review

Description Tamara Roberson 2004-12-27 08:06:36 UTC
Muine-CVS-20041226-SignalUtils.patch
-------------------------------

NOTE:
This patch should not change how Muine works. If it does, it's a bug!


Overview:

2004-12-26  Tamara Roberson  <foxxygirltamara@gmail.com>

	* src/SignalUtils.cs:

	Added a SignalUtils class with SignalDelegates and SignalConnect which
	wraps g_signal_connect_data.

	* src/HandleView.cs:
	* src/MmKeys.cs:
	* src/Player.cs:
	
	Changed all SignalDelegates to use the ones in SignalUtils. Also
	changed the calls to g_signal_connect_data to use 
	SignalUtils.SignalConnect. Removed SignalDelegates and 
	g_signal_connect_data.
	
	
Description:

Cleaned up the use of g_signal_connect_data when dealing with unmanaged 
objects. 

Although you can't overload external functions, you can overload C# functions
which wrap them. Muine was using internal classes which contained the 
functions (in src/Player.cs), overloaded wrappers make this much cleaner.
Comment 1 Tamara Roberson 2004-12-27 08:07:12 UTC
Created attachment 35214 [details] [review]
Muine-CVS-20041226-SignalUtils.patch
Comment 2 Jorn Baayen 2004-12-27 18:48:45 UTC
Committed also, more thanks! :)