After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 161736 - Needs to send a _NET_ACTIVE_WINDOW message when clicked on
Needs to send a _NET_ACTIVE_WINDOW message when clicked on
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: mini-commander
git master
Other All
: High major
: 2.10
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on: 161735
Blocks:
 
 
Reported: 2004-12-19 23:27 UTC by Elijah Newren
Modified: 2005-01-08 01:19 UTC
See Also:
GNOME target: 2.10.0
GNOME version: 2.9/2.10

Attachments
Request focus when clicked on (866 bytes, patch)
2005-01-07 01:26 UTC, Elijah Newren 		none Details | Review

Description Elijah Newren 2004-12-19 23:27:31 UTC 
See bug 161735 for more details; basically Metacity won't be focusing the panel
on click unless it receives a _NET_ACTIVE_WINDOW message for the panel.  So, in
order for the command line applet to work, it needs to send such a message.
Comment 1 Danielle Madeley 2004-12-20 03:36:34 UTC 
So this is going to break mini-commander, gdict, and contact-lookup-applet (as
well as possibly others). However there is no way for them to send this focus
request without solving 161736? *whimpers*
Comment 2 Elijah Newren 2004-12-20 04:03:14 UTC 
Uhm....yeah.  Sorry.

I have some patches against libpanel-applet for 161735, and for gdict to test
things out.  But those patches tried a different solution that didn't quite work
(they were at least close--if I had the appropriate window id for the containing
panel, it would have...)
Comment 3 Luis Villa 2005-01-06 04:26:44 UTC 
I'm leaving the GNOME 2.10 milestone on this one; we can't break these applets,
can we?
Comment 4 Elijah Newren 2005-01-07 01:26:10 UTC 
Created attachment 35591 [details] [review]
Request focus when clicked on

This patch fixes the problem, though it depends on the patch in bug 161735
being applied first (and thus being accepted first)...
Comment 5 Elijah Newren 2005-01-07 16:48:36 UTC 
The patch in bug 161735 has been committed.  Okay to commit this patch?
Comment 6 Danielle Madeley 2005-01-07 16:53:19 UTC 
Yeah, that seems fine. I trust your judgement on this.
Comment 7 Elijah Newren 2005-01-07 17:31:18 UTC 
committed.
Comment 8 Elijah Newren 2005-01-07 19:06:20 UTC 
Oops.  As Mark pointed out, I should have updated configure.in to depend on the
newest libpanel-applet.  Okay to commit the following change?

Index: configure.in
===================================================================
RCS file: /cvs/gnome/gnome-applets/configure.in,v
retrieving revision 1.350
diff -p -u -r1.350 configure.in
--- configure.in        7 Jan 2005 16:35:19 -0000       1.350
+++ configure.in        7 Jan 2005 19:06:01 -0000
@@ -28,7 +28,7 @@ LIBGNOMEUI_REQUIRED=2.8.0
 GNOME_VFS_REQUIRED=2.8.0
 GCONF_REQUIRED=2.8.0
 SCROLLKEEPER_REQUIRED=0.1.4
-LIBPANEL_REQUIRED=2.8.0
+LIBPANEL_REQUIRED=2.9.4
 LIBGTOP_REQUIRED=2.8.0
 LIBGLADE_REQUIRED=2.4.0
 LIBGAIL_REQUIRED=1.1.0
Comment 9 Danielle Madeley 2005-01-08 00:49:51 UTC 
Yep (although I'm now going to have to start running CVS panel again).
Comment 10 Elijah Newren 2005-01-08 01:19:26 UTC 
ok, done.  Thanks.