After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 158564 - More cities of China wanted
More cities of China wanted
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: gweather
git master
Other All
: Normal minor
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks: 150905
 
 
Reported: 2004-11-17 18:51 UTC by Funda Wang
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10


Attachments
Patch against HEAD (3.48 KB, patch)
2004-11-19 11:06 UTC, Funda Wang
accepted-commit_now Details | Review

Description Funda Wang 2004-11-17 18:51:39 UTC
So few cities of China. It would be better add more. Check here:

Other information:
http://www.telcom.es/~gacias/arpt/china.htm
http://worldaerodata.com/countries/China.html
Comment 1 Danielle Madeley 2004-11-18 02:28:07 UTC
We will accept a patch against the CVS version of Locations.xml.in

(You can get this from
http://cvs.gnome.org/viewcvs/gnome-applets/gweather/Locations.xml.in)
Comment 2 Funda Wang 2004-11-19 11:06:51 UTC
Created attachment 33932 [details] [review]
Patch against HEAD

Then, here is the patch.
Comment 3 Danielle Madeley 2004-11-19 13:51:04 UTC
Comment on attachment 33932 [details] [review]
Patch against HEAD

That looks pretty good. Do you have commit access?

Clear to commit to HEAD.
Comment 4 Funda Wang 2004-11-19 14:07:35 UTC
Just committed. Thanx.

Will close as fixed.