After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 157079 - Type mismatches and inconsistancies in property types all around.
Type mismatches and inconsistancies in property types all around.
Status: RESOLVED FIXED
Product: glade
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Glade 3 Maintainers
Glade 3 Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-11-01 21:20 UTC by Tristan Van Berkom
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
This abolishes GladePropertyType. (67.97 KB, patch)
2004-11-01 21:25 UTC, Tristan Van Berkom
none Details | Review
Yet another uber patch. (87.42 KB, patch)
2004-11-02 21:36 UTC, Tristan Van Berkom
none Details | Review

Description Tristan Van Berkom 2004-11-01 21:20:01 UTC
I am about to abolish GladePropertyType.
Comment 1 Tristan Van Berkom 2004-11-01 21:25:02 UTC
Created attachment 33321 [details] [review]
This abolishes GladePropertyType.

This patch:

* Removed GladePropertyType completely from the source in favor of GParamSpec.
* Removed GladeChoice code, and replaced all references thereof
* Custom types must now provide a function to retrieve a GParamSpec for that
  type.
* xml files updated accordingly.

Basicly, now all of the enum/flag work is done entirely through introspection
and there is no possibility of mismatches across real property types and
glade property types, as they are always the same type.

This patch also means:
    cvs rm src/glade-choice.[ch]

Ultimately, I think we can do away with glade-param.[ch] also, but I'm not
so so sure about that yet (its definitly less of an urgent matter).
Comment 2 Tristan Van Berkom 2004-11-02 21:36:32 UTC
Created attachment 33361 [details] [review]
Yet another uber patch.

This is an extention to the previous patch, here is the ChangeLog entries:

* Removed GladePropertyType completely from the source in favor of GParamSpec.
* Removed GladeChoice code, and replaced all references thereof
* Custom types must now provide a function to retrieve a GParamSpec for that
  type (xml files and glade-gtk backend updated accordingly).
* Removed "child" member from GladePropertyType in order to avoid confusion
  (Note, I will add support for non-widget types + all types allowed to have
  children, in a more flexable way, for now I got rid of all mention of "child"

  since it wasn't implemented and mostly `#if 0'd out anyway)
* Implemented <VerifyFunction> in xml files and in the glade-gtk backend.
* Added support for numerical types long/ulong/int64/uint64 to the editor.
* src/glade-project.c: glade_project_remove_widget() Now removes nodes on
widget
  to remove, this fixes bug 156515.
* src/glade-editor.c: Fixed popup name to
  g_strdup_printf(_("Create a %s"), type);
Comment 3 Tristan Van Berkom 2004-11-02 21:39:21 UTC
Note when patching this in, the VerifyFunction is bug 156735
(just to save you a little time :-)

Cheers.
Comment 4 David Hoover 2004-11-03 05:53:19 UTC
committed