After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 156677 - ctrl+S should be the save shortcut, not the Slide Show
ctrl+S should be the save shortcut, not the Slide Show
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on:
Blocks:
 
 
Reported: 2004-10-28 10:11 UTC by Sebastien Bacher
Modified: 2005-01-06 10:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
The Patch (356 bytes, patch)
2005-01-06 08:51 UTC, Naveen Chandran V
none Details | Review

Description Sebastien Bacher 2004-10-28 10:11:29 UTC
According to the GNOME HIG:
http://developer.gnome.org/projects/gup/hig/2.0/input-keyboard.html#shortcuts
"Save	Ctrl-S	Save the current document"

That's pretty confusing to have this shortcut used for a different item in
gthumb ...
Comment 1 Naveen Chandran V 2005-01-06 07:06:34 UTC
Yes, ctrl+s and just the 's' does the same operation!

ctrl+s is should be the save shortcut

-Naveen
Comment 2 Naveen Chandran V 2005-01-06 07:16:21 UTC
But already we have Shift+Control+S for saveas will it be ok if we change it to
ctrl+s for saveas. Because we don't have a 'save' option, we have only 'saveas'
Plz Comment.

-Naveen
Comment 3 Naveen Chandran V 2005-01-06 07:23:10 UTC
One of the Guideline is


# Do not use any of the standard shortcut keys listed in the section called
“Standard Application Shortcut Keys” for your own purposes, even if your
application doesn't support those functions. This helps reinforce consistency
between all GNOME applications.

Is it just enough to remove ctrl+s shortcut. or should it be removed and also
assigned to 'saveas'?
Comment 4 Naveen Chandran V 2005-01-06 08:51:29 UTC
Created attachment 35534 [details] [review]
The Patch

This attachment contains a patch that changes ctrl+s as saveas shortcut.

2005-01-06 Naveen & Team <naveenchandranv@gmail.com>

    * Fixed bug #156677 (http://bugzilla.gnome.org/show_bug.cgi?id=156677).
      Removed shortcut ctrl+s for slide-show and assigned it to saveas.
Comment 5 Naveen Chandran V 2005-01-06 08:59:09 UTC
The shortcut for save as specified in Help-> Keyboard shortcuts is 's -
Start/Stop the slideshow' but ctrl-s also does the same thing hence the above
patch would assign the shortcut ctrl-s to saveas(since there is no 'save' option
and also there is no shortcut for the 'save as' option).

--Naveen & Team
Comment 6 Paolo Bacchilega 2005-01-06 10:03:31 UTC
fixed now, thank you.