GNOME Bugzilla – Bug 155735
Crashed when rearranging groups for a contact.
Last modified: 2005-05-05 14:52:43 UTC
Distribution: Debian 3.1 Package: gossip Severity: normal Version: GNOME2.8.0 0.7.8 Gnome-Distributor: Debian Synopsis: Crashed when rearranging groups for a contact. Bugzilla-Product: gossip Bugzilla-Component: General Bugzilla-Version: 0.7.8 BugBuddy-GnomeVersion: 2.0 (2.8.0) Description: Description of the crash: Crashed when rearranging groups for a contact. I noticed one of my contacts was filed under "Unsorted". Opened the groups editor, selected the group where he should be in, and suddenly gossip froze. After some clicking here and there, the crash dialog showed up. How often does this happen? Has happened once so far. Debugging Information: Backtrace was generated from '/usr/bin/gossip' (no debugging symbols found)...Using host libthread_db library "/lib/tls/libthread_db.so.1". (no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...[Thread debugging using libthread_db enabled] [New Thread 1088754976 (LWP 3651)] (no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...0x40b3840e in __waitpid_nocancel () from /lib/tls/libpthread.so.0
+ Trace 51127
------- Bug moved to this database by unknown@bugzilla.gnome.org 2004-10-18 11:14 ------- Unknown version 0.7.8 in product gossip. Setting version to "0.7.X". Unknown platform unknown. Setting to default platform "Other". Unknown milestone "unknown" in product "gossip". Setting to default milestone for this product, '---' Setting to default status "UNCONFIRMED". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
The same thing happened to me today. Gossip 0.7.8-2 from Debian.
Same here. 0.7.8-2 / Debian.
*** Bug 168172 has been marked as a duplicate of this bug. ***
Last duplicate was on gentoo using 0.8.. Enough dups to confirm it.. I'm not sure at all how to reproduce tho. Seems like 132337 is also a dupe.
*** Bug 169987 has been marked as a duplicate of this bug. ***
Here's how to reproduce this bug: http://bugs.gentoo.org/show_bug.cgi?id=79297
Created attachment 45501 [details] [review] Adds edit groups and rename group functionality. Since the merge with the session-rewrite branch the Edit Groups and Rename Group functionality has not been joined up with the new code. This patch does just that.
Created attachment 45502 [details] [review] Small fix on last patch Doesn't show offline contacts when you rename a group (if they are not mean't to be shown)
Added Patch keyword.
In contact_list_find_contact_foreach: /* we want to find ALL contacts that match, this means if we have the same contact in 3 groups, all iters should be returned. */ return FALSE; } Why do you return FALSE? All hits are added to fc->iters, so why return that we didn't find any hits?
Also, I don't think that the OK-button should be insensitive when you haven't changed something in the dialog. Could you look into these two matters and apply a new patch and I'll take a quick look at it.
Regarding #10: It is required on the premiss that you can have a contact (e.g. micke@imendio.com) in multiple groups ("Jabber", "Friends" and "Work" for example). If you return TRUE then the foreach returns and doesn't continue to iterate the contact list. This is a problem when a contact is shown in 3 different groups because only the first instance is put into fc->iters. As a result you end up with 1 out of 3 flashing or in the correct state (Away, etc). Regarding #11: I'll get a patch out ASAP.
Ah, sorry, I was tired yesterday when looking at the patch, of course you're right.
Created attachment 45603 [details] [review] Updated. Added insensitive OK button in the Edit Groups dialog.
Martyn, do you think you could modify the patch to apply to the new code structure? Thanks,
Created attachment 45901 [details] [review] Reworked to fit in with the new code reorg.
Commited to CVS.