After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 154651 - Color picker window interferes with CTRL for next pick
Color picker window interferes with CTRL for next pick
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Tools
2.0.x
Other All
: Normal trivial
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2004-10-06 08:52 UTC by Shaneyfelt
Modified: 2005-02-06 23:32 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Shaneyfelt 2004-10-06 08:52:30 UTC
IMHO, ctrl key/radio button interaction could 
be improved for the color picker.

When using Color Picker, ctrl currentlty
toggles between Set Foreground Color and
Set Background Color - which makes sense,
but there are a couple of problems in how
it is implemented.

1. The color picker dialog pops up on the
first click and becomes the active window.
While the color picker dialog is is the 
active window, the ctrl key does not 
toggle the the mode.

2. The "Pick Only" mode currently disables
the ctrl key from changing modes. It would 
seem more consistent if the "Pick Only" 
mode would not disable the ctrl key from 
changing modes, but I can see the reasoning 
behind this (if someone bumps the ctrl 
key and doesn't know about the feature, 
maybe it should remain in pick only mode - 
but I think maybe we could remember which 
mode was without CTRL, and return to the
appropriate mode when released to address
that issue)

This is tested on: GIMP2.0.4; GTK+2.4.3;
Win2K,v5,sp6; and I don't know whether 
all of the problems occur under different 
configurations.
Comment 1 Sven Neumann 2004-10-06 10:52:11 UTC
(1) is not a bug. If you dislike the window getting the focus, change your WM
not to give focus to new windows (or to this window in particular).

(2) is completely intentional and I don't see how it could be changed reasonably.

This report should IMHO be closed as NOTABUG.
Comment 2 Sven Neumann 2004-10-06 11:03:37 UTC
OK, we can do something about (1) as soon as we depend on GTK+-2.6. We can then
use gtk_window_set_focus_on_map() to set a window manager hint that should keep
the window from getting the focus when it appears on screen. But since this
feature is only in GTK+-2.6, this will have to wait.
Comment 3 Sven Neumann 2005-02-06 23:32:58 UTC
2005-02-07  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimptooldialog.c (gimp_tool_dialog_new): unset the
	"focus-on-map" property for tool dialogs. Fixes bug #154651 (on
	window managers supporting this hint).