GNOME Bugzilla – Bug 152928
Inclusion of trashapplet in gnome-applets
Last modified: 2004-12-22 21:47:04 UTC
Finally here's my request :-). I would really like it if my Trash Applet (http://luon.net/~michiels/trashapplet) would be included in gnome-applets. I think it would be a useful contribution to the current applets. Some current features are: - DND files onto the applet to move them to the trash. - Display how many objects are in Trash by pointing your mouse on the applet. - Icon on the applet displays the current state of the Trash (full/empty) I've already received lots of patches from people and some positive reactions. Ubuntu (http://ubuntulinux.org) already has a patched version in their distribution. I would really like to be able to make use of Gnome Bugzilla, Gnome CVS and the other services so it will be easy to organise the bugreports, and let more people work on the applet. Cheers, Michiel
Just to confirm, the applet is cool and works pretty fine. It would be nice to get it integrated to gnome-applets soon.
I agree, I want to put it in. JamesH indicated over beer, that Canonical had a raft of patches that will be useful to GNOME as well. Michiel, I am under the impression that you don't have CVS access. That should be fine for the moment, as you can work through me, or one of the other maintainers, for the time being. The easiest way for you to get it in is to provide me with a patch that adds it to the latest GNOME-Applets (cvs HEAD), including automake-fu in the base Makefile.am and configure.in.
I wonder if it wouldn't be better in Nautilus itself? Trash Applet in gnome-applets will have strange effects on the dependency graph. :-)
Does it depend on anything in Nautilus? I was under the impression it only depended on things in GNOME-VFS.
It does actually also depend on libeel. Which is rather overkill actually because it only uses one variable: EEL_TRASH_URI. I /could/ replace that by a hardcoded "trash:", which is dirty, but drops the depend.
Oh, another note. Since I've received more patches and am applying them in the luon.net CVS repository I notice we depend on some more things than only EEL_TRASH_URI. So I think the libeel depedancy is pretty nesscairy.
Ok, here is the patch to add trashapplet to gnome-applets. I've tested it, so it works. I haven't migrated the po files though, but I'll do this when trashapplet hits gnome-applets.
Created attachment 31700 [details] [review] Patch to add trashapplet to gnome-applets
Ok, this is now committed to CVS. http://cvs.gnome.org/viewcvs/gnome-applets/trashapplet/ Check to make sure all the appropriate files are present. I'll get all the appropriate component added to Bugzilla. Is there anything else that will need doing?
Ok, thank you this is great! :-) I will test the build (again) as soon as I get home. The only thing I can think of is updating the po files so it includes the trashapplet strings. I will apply for a CVS account as soon as possible, so I can edit the code myself.
One bug that is probably worth considering is this one reported against the Ubuntu preview: https://bugzilla.ubuntu.com/show_bug.cgi?id=1416 Currently the trash applet only works with the ~/.Trash folder and not the separate Trash folders created on other volumes (floppy disks, NFS volumes, etc). This means that trash applet might think the trash is empty when nautilus thinks it is full, and sometimes moving files to the trash with trash applet can take longer since it might have to copy the contents over the network.
Assigning this bug (and therefore all future bugs) to the trash component. I have updated the .server file to reflect the correct bugzilla information.
I think the migration went succesfully, translations should be automatically updated by the GTP scripts. Closing this bug.
Additional features like eject CD/DVD when you DND the CD/DVD icon over the trash applet, and disconnect/umount drives when you DND the drive icon over the trash applet (all OSX-like features) would be great! /maybe change the icon of the trash applet - at hold the CD/DVD or device over the applet - to an eject or something similar icon/