After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 152620 - Small icon (hIconSm member)
Small icon (hIconSm member)
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
unspecified
Other All
: Normal enhancement
: Small fix
Assigned To: gtk-win32 maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2004-09-14 15:23 UTC by Kazuki Iwamoto
Modified: 2006-10-29 00:11 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
gdkwindow-win32.c's patch for gtk+-2.4.9 (1.46 KB, patch)
2004-09-14 15:24 UTC, Kazuki Iwamoto
needs-work Details | Review
patch for gdkwindow-win32.c (2.21 KB, patch)
2006-10-14 08:12 UTC, Kazuki Iwamoto
none Details | Review

Description Kazuki Iwamoto 2004-09-14 15:23:01 UTC
The small icon is not initialized at RegisterGdkClass in gdkwindow-win32.c.
It is better to initialize the small icon (hIconSm member).
Comment 1 Kazuki Iwamoto 2004-09-14 15:24:58 UTC
Created attachment 31547 [details] [review]
gdkwindow-win32.c's patch for gtk+-2.4.9
Comment 2 Tor Lillqvist 2004-09-15 18:30:54 UTC
Wouldn't it be better to use a copy of the large icon as small icon if there is 
no small icon in the application's .exe's resources? Also, your patch loses the 
functionality that if the application .exe has no icon, the icon in the GDK DLL 
is used. Otherwise you are correct that it would be a good idea to try to 
extract a separate small icon.
Comment 3 André Klapper 2006-10-07 16:16:33 UTC
updating patch status as per last comment.

kazuki, can you update this patch?
Comment 4 Kazuki Iwamoto 2006-10-12 21:00:33 UTC
After that, I evaded a problem by using gtk_window_set_default_icon_list.
The programs that I made were settled, but generally the problem was left.

I confirmed that this problem occurred equally on latest version (GTK+-2.10.6).

I will participate in "CodeFest Kyoto 2006" tomorrow.
I add it to one of my plans there.
If I get a good idea, I am going to update patch.
Comment 5 Kazuki Iwamoto 2006-10-14 08:12:01 UTC
Created attachment 74677 [details] [review]
patch for gdkwindow-win32.c

I updated a patch for latest version.

If the application not has no icon, the icon in the GDK DLL is used.
And if there is only an icon of either, it is used as both.
Comment 6 Tor Lillqvist 2006-10-29 00:11:28 UTC
Thanks, applied to HEAD and gtk-2-10.

2006-10-29  Tor Lillqvist  <tml@novell.com>

	* gdk/win32/gdkwindow-win32.c (RegisterGdkClass): Improve handling
	of the small icon of the window class. (#152620, Kazuki Iwamoto)