After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 152607 - querymodules.c backslash encode (escape_string)
querymodules.c backslash encode (escape_string)
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: win32
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
pango-maint
Depends on:
Blocks:
 
 
Reported: 2004-09-14 14:41 UTC by Kazuki Iwamoto
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for backslash encode (307 bytes, patch)
2004-09-14 14:44 UTC, Kazuki Iwamoto 		none Details | Review

Description Kazuki Iwamoto 2004-09-14 14:41:45 UTC 
Please describe the problem:
escape_string in querymodules.c is encoding LF and quotation mark.
But backslash is not encoded.
On Windows, paths are divided by backslash.
Therefore it will be fault.

Steps to reproduce:
1. run pango-querymodules.exe


Actual results:
output example
"C:\Documents and Settings\iwm\My
Documents\Source\gtk\lib\pango\1.4.1\modules\pango-basic-win32.dll"
BasicScriptEngineWin32...


Expected results:
Backslash is encoded.

Does this happen every time?
When path has space.

Other information:
Comment 1 Kazuki Iwamoto 2004-09-14 14:44:09 UTC 
Created attachment 31544 [details] [review]
patch for backslash encode
Comment 2 Tor Lillqvist 2004-09-15 19:25:54 UTC 
escape_string() is called only if string_needs_escape() return TRUE, so that 
function needs to check for backslash, too. Otherwise OK, fixed in HEAD and 
pango-1-4.