GNOME Bugzilla – Bug 150608
add colors after palette editor cursor
Last modified: 2005-07-13 16:24:11 UTC
this patch makes rearrangement of the palette relatively painless. it does this by inserting added colors after the current cursor position rather than the end of the list. i'd also like to make it insert dropped colors after the color they were dropped on, but don't know if i can obtain the coordinates of the drop in order to determine this.
Created attachment 30773 [details] [review] changes the palette editor to add colors after the cursor
Thanks to fixing bug #150030, gimp_palette_add_entry() has a "position" parameter now and dropped colors are inserted at the right place. It seems like the logical next step to apply the rest of this patch, however I'm unsure if the color should be inserted *at* or *after* the currently selected color. Opinions?
IMO the drop cursor should indicate where the color is inserted, that is between two colors.
I wanted to implement that but didn't understand how. Probably best to insert before the color it was dropped on if it was dropped on the left half of a color panel, and after if dropped on the right half.
Note we don't talk about DND here. That's already implemented in HEAD and just needs to be refined. This bug is about inserting new colors before or after the cursor position.
I think after more common (most obviously for adding to the end of the palette.).
Fixed in CVS: 2005-07-13 Michael Natterer <mitch@gimp.org> * app/widgets/gimppaletteeditor.c (gimp_palette_editor_pick_color): add colors after the cursor. Fixes bug #150608.