After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 150295 - [PATCH] HIG cleanup for connect to server dialog
[PATCH] HIG cleanup for connect to server dialog
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
0.x.x [obsolete]
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-08-16 21:21 UTC by Dennis Cranston
Modified: 2005-08-29 00:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch file. (2.93 KB, patch)
2004-08-16 21:21 UTC, Dennis Cranston 		none Details | Review
Screenshot of proposed changes. (15.25 KB, image/png)
2004-08-16 21:24 UTC, Dennis Cranston 		  Details
Updated proposed patch. (3.92 KB, patch)
2004-08-17 16:20 UTC, Dennis Cranston 		needs-work Details | Review

Description Dennis Cranston 2004-08-16 21:21:22 UTC 
1.  Fix widget padding.
2.  Fix mnemonic conflict for "N" in the new 'Browse Network' button.
Comment 1 Dennis Cranston 2004-08-16 21:21:52 UTC 
Created attachment 30611 [details] [review]
Proposed patch file.
Comment 2 Dennis Cranston 2004-08-16 21:24:17 UTC 
Created attachment 30612 [details]
Screenshot of proposed changes.
Comment 3 Dennis Cranston 2004-08-17 16:20:08 UTC 
Created attachment 30666 [details] [review]
Updated proposed patch.

2004-08-17  Dennis Cranston <dennis_cranston at yahoo com>

	* src/nautilus-connect-server-dialog.c:
	HIGify widget padding.	Fix mnemonic conflict of 'N' caused by
	'Browse Network' button.  Use sentence case for 'User name:' 
	field.
Comment 4 Martin Wehner 2004-08-21 15:03:30 UTC 
Thanks for the patch. Confirming.
Comment 5 Alexander Larsson 2004-08-24 13:30:24 UTC 
We're string frozen, so i commited the non-string portions of the patch.
Comment 6 Alexander Larsson 2004-08-24 13:36:05 UTC 
Adding blocked_by_freeze keyword for string changes.
Comment 7 Christian Neumair 2004-10-20 14:05:34 UTC 
Comment on attachment 30666 [details] [review]
Updated proposed patch.

The patch doesn't apply cleanly anymore. You may want to update it to HEAD
Dennis. Thanks for your efforts.
Comment 8 Dennis Cranston 2004-10-20 15:36:38 UTC 
See comment number 5, the patch doesn't apply cleanly because Alex already
applied the patch to CVS minus the string changes.
Comment 9 Christian Neumair 2004-10-20 16:27:29 UTC 
...so it should be perfectly fine to commit the rest to HEAD.
Comment 10 Elijah Newren 2004-10-20 17:01:35 UTC 
Chris: No.  nautilus hasn't branched yet, so it's still string frozen.  It's
okay once nautilus has branched.
Comment 11 Dennis Cranston 2004-12-29 04:28:30 UTC 
Nautilus has branched.  Is it okay to commit?
Comment 12 Stef Walter 2005-08-29 00:42:29 UTC 
Seems like all aspects of this bug have been fixed and patches committed.
Closing the bug.