GNOME Bugzilla – Bug 149270
gnome-score doesn't handle blank real name fields in the passwd file properly (patch included).
Last modified: 2005-01-25 12:20:42 UTC
Play gnomine as a user with no real name field in /etc/passwd. Get a high score and Unknown appears rather than falling back to the user name. This is the result of the code expecting g_get_real_name () to return NULL, instead it returns the string "Unknown" and has since about 1999. The attached patch fixes this by explicitly looking for the string "Unknown" and subsituting the user name instead. For more details see bugs #149204 and #143552. The use of a hard-coded (and untranslated) string is a little bad, but since I intend moving this functionality into gnome-games in the 2.9 time-frame this shouldn't matter. I also get the impression the glib maintainer isn't going to change the string anytime soon. Can I commit the patch ?
Created attachment 30198 [details] [review] Patch to detect the use of an "Unknown" user name and do something saner.
For what it's worth, in CVS on November 12th, libgnome's gnome-score was marked deprecated...
Is this important enough to make an effort to get it in for 2.10?
Probably. We haven't replaced the problem code at the gnome-games end (we should do, but it won't happen for 2.10) and some distributions (gentoo at least) have stopped filling in the real name field so the user experience is bad. We have had multiple bugs filed about this.
Comment on attachment 30198 [details] [review] Patch to detect the use of an "Unknown" user name and do something saner. Commited on both branches.