After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 147665 - Patch for gnome-theme-manager handle background in themes
Patch for gnome-theme-manager handle background in themes
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] theme-manager
2.10.x
Other All
: High enhancement
: 2.14
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-07-15 17:17 UTC by Adriano Del Vigna
Modified: 2006-01-03 10:07 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
Metatheme background handling (2.60 KB, patch)
2004-07-15 17:19 UTC, Adriano Del Vigna 		none Details | Review
Updated patch to the current cvs code (2.50 KB, patch)
2004-07-24 16:18 UTC, David Sedeño Fernández 		none Details | Review
new patch (5.99 KB, patch)
2004-10-24 19:15 UTC, Sebastien Bacher 		needs-work Details | Review
updated to current cvs (7.11 KB, patch)
2005-12-30 16:08 UTC, Guillaume Desmottes 		committed Details | Review

Description Adriano Del Vigna 2004-07-15 17:17:55 UTC 
Add the handle of background images for metathemes. 
So 'BackgroundImages' directives in 'index.theme' 
files are handled properly.

With this patch the 'Apply Background' button works.
Comment 1 Adriano Del Vigna 2004-07-15 17:19:06 UTC 
Created attachment 29559 [details] [review]
Metatheme background handling

See bug report comments...
Comment 2 David Sedeño Fernández 2004-07-24 16:18:59 UTC 
Created attachment 29853 [details] [review]
Updated patch to the current cvs code

I have looked a bit for a theme that have background suggestion to probe to
patch, but I didn't find one. Do you known one ?
Comment 3 Adriano Del Vigna 2004-07-26 18:56:59 UTC 
I have made one...

But you can test it editing an existing one. It's easy.

Just add one line like:

BackgroundImage=path/to/the/image.jpg

To an index.theme file, from a theme (usualy at /usr/share/themes).

It should work. If you can't, I can e-mail the one I made for you.
Comment 4 Sebastien Bacher 2004-10-24 19:15:39 UTC 
Created attachment 33004 [details] [review]
new patch

Updated patch. Instead of rewriting a different code I've copied the existant
"fonts" code for the background part.
I've also fixed 2 smalls problems:
- connected the signals to the second versions of the buttons (mode for themes
with background and font)
- updated the button state after the displaying of the list at startup

To test this you just need to add a "BackgroundImage=" and/org a
"ApplicationFont=" to the index.theme.

The changes work fine here, permission to commit to HEAD ?
Comment 5 Adriano Del Vigna 2004-10-25 12:20:24 UTC 
Ok for me.
Comment 6 Kjartan Maraas 2005-02-01 23:58:13 UTC 
Probably not going to make 2.10 since it's a feature?
Comment 7 Sebastien Bacher 2005-02-05 14:55:01 UTC 
Comment on attachment 33004 [details] [review]
new patch

right, I'm marking it as commit_after_freeze
Comment 8 Sebastien Bacher 2005-12-30 15:03:16 UTC 
The patch needs to be updated for the current CVS. Could you do that and then commit it?
Comment 9 Guillaume Desmottes 2005-12-30 16:08:32 UTC 
Created attachment 56553 [details] [review]
updated to current cvs

I made a simple test and it seems to wrong right on current cvs.
Comment 10 Sebastien Bacher 2005-12-30 16:44:50 UTC 
s/wrong/work you mean? Thank you for the update, feel free to commit it
Comment 11 Rodrigo Moya 2006-01-03 10:07:08 UTC 
Patch committed to HEAD, thanks