GNOME Bugzilla – Bug 145217
Radio station searches limit the genre on restart
Last modified: 2005-08-04 13:33:40 UTC
This bug has been reported in the Debian BTS: http://bugs.debian.org/257035 "It's hard to describe this bug, so I'll just go over the steps for reproducing it: 1) Go the radio stations source. 2) Type some text in the search box, to limit the list of radio stations down. 3) Quit Rhythmbox. 4) Restart Rhythmbox. After you restart Rhythmbox, the list of genres in the radio station browser will only have those genres in the radio stations matched by the search that was saved when you quit Rhythmbox the previous time. This is really obvious if your search only matched one radio station: only that station's genre will be listed in the genre menu, under "All". Even if you clear the search, the list of genres remains limited. After this happens, it's effectively impossible to browse radio stations by genre. I expect the search to never limit the list of genres, as is the case before you quit Rhythmbox, and when browsing the Library." ------ I can reproduce the bug here and I've a crasher with it too ... 1- go in radio, do a search (to limit the genre) 2- restart rb 3- go in radio again, the seach entry has kept its state/result 4- the genre list only contain radio listed by the result of the research (the only radio displayed) 5- clear the search field ... the other radios are showed, but the genre list is not updated 6- try to change the genre of a radio which has a genre not listed in the current state of the UI 7- crash Backtrace was generated from '/usr/bin/rhythmbox' Using host libthread_db library "/lib/tls/libthread_db.so.1". [Thread debugging using libthread_db enabled] [New Thread 1088807392 (LWP 13512)] [New Thread 1143851952 (LWP 13518)] [Thread debugging using libthread_db enabled] [New Thread 1088807392 (LWP 13512)] [New Thread 1143851952 (LWP 13518)] [Thread debugging using libthread_db enabled] [New Thread 1088807392 (LWP 13512)] [New Thread 1143851952 (LWP 13518)] [New Thread 1125317552 (LWP 13516)] [New Thread 1116928944 (LWP 13515)] [New Thread 1108540336 (LWP 13514)] [New Thread 1100151728 (LWP 13513)] 0x40bab431 in __waitpid_nocancel () from /lib/tls/libpthread.so.0
+ Trace 47281
Thread 1 (Thread 1088807392 (LWP 13512))
*** Bug 143443 has been marked as a duplicate of this bug. ***
Created attachment 50225 [details] [review] fix This was caused by the iradio source running its setup query before the database load was complete (so it didn't return any results), then attaching the genre property model to the query used to perform the search, so that when the iradio entries were eventually loaded, the property model only saw those entries that matched the search. The crashes seen were caused by bug 149799. This patch introduces a cached 'all' query for the iradio source, and uses only that query to update the genre property model.
2005-08-04 James Livingston <jrl@ids.org.au> * sources/rb-iradio-source.c: (rb_iradio_source_dispose), (rb_iradio_source_do_query): Patch from Jonathan Matthew <jonathan@kaolin.hn.org> that stops the iradio source attempting to use a query before the database it fully loaded. (Closes 145217) Also removed unused fields from RBIRadioSourcePrivate.