After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 144866 - [flac] seeking broken, duration not set on buffers [PATCH]
[flac] seeking broken, duration not set on buffers [PATCH]
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other Linux
: Normal normal
: 0.8.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-06-23 13:53 UTC by Tim-Philipp Müller
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (952 bytes, patch)
2004-06-23 13:55 UTC, Tim-Philipp Müller
none Details | Review

Description Tim-Philipp Müller 2004-06-23 13:53:45 UTC
The attached patch fixes two problems with flacdec: 
 
* seeking in flacs doesn't work 
 
* some sinks (e.g. artsdsink, nassink) report wrong values on doing 
gst_element_query(), e.g. artsdsink reports '11 seconds' where it should 
report a time position of '1 seconds'. Setting the duration on the buffer 
seems to fix that. 
 
 
I also think the whole block where gst_pad_set_explicit_caps() is called is 
called (line 493-506) should be moved to the beginning of the function, but as 
it doesn't seem to be necessary to make things work I've left it as it is. 
 
Cheers 
 -Tim
Comment 1 Tim-Philipp Müller 2004-06-23 13:55:43 UTC
Created attachment 28952 [details] [review]
proposed patch
Comment 2 David Schleef 2004-07-03 04:20:21 UTC
Looks good, applied.