GNOME Bugzilla – Bug 144801
Smiley face button too small?
Last modified: 2004-12-22 21:47:04 UTC
[ forwarded from http://bugs.debian.org/255622 ] "I just upgraded from the 2.4.x version, and I noticed that the smiley face icon in the button above the GNOME Mines playing field seems clipped. Is this on purpose, or should the button be made bigger?" The same happens here, and it doesn't seem to be caused by the GTK+ engine.
The image isn't clipped, it is being displayed exactly as it was in the 1.4 version of gnome-games. However, the button underneath has changed appearance and now has a dotted line (since it is the default button). This dotted line accentuates the flat edges to the circle that the face has. Also, the anti-aliasing for the icon was done against a slightly different background colour, so the border of not-quite-right grey pixels also enhances the effect. I've been meaning to removes the dotted line for a while now and I'll look into making a properly anti-aliased set of icons (i.e. PNGs rather than the current xpms).
Right, this impression must be given by the dotted line. As for better icons, I'm sure everyone would appreciate, especially if these were SVGs :)
I've made a couple of changes to try and fix this. Firstly, the dotted line is now outside the button (it can't easily be removed entirely). Secondly, I've rebuilt the xpm face art in png format with a proper alpha channel. There is still some slight clipped look, but that is in the original artwork and can't easily be fixed.
I am definitely seeing a cropped face in gnomine when I upgraded from gtk+ 2.4 to gtk+ 2.5.1 (on Fedora Core, multiple machines, CVS gtk+ won't compile for me at the moment)... Not sure if this is some sort of transient gtk+ bug, but probably worth mentioning. http://www.rahga.com/png/bug_gnomine_gtk2p5p1.png
Yeah, I've just started seeing it in a freshly installed Debian 3.1 system. Before I saw this I had assumed that what joss was seeing was the thing I fixed (a far more subtle effect). It looks like a GTK bug, but I'm reopening it here until I can investigate further. At the very least I should be able to find a workaround.
Found it ! There is a little bit of code in the middle of all the widget-layout code that explicitly set the size of the button. This has always been there, but until recently this had, for some reason, worked. I don't know whether it is a theme-related thing or just that GTK was changed to work correctly. In any event it is fixed now in CVS. Hopefully this will appear in a tarball release on Monday.
As a follow up note for anyone doing partial upgrades, this gnomine patch didn't look right on the older versions of gtk+-2.4, but it looks fine on gtk+- 2.4.9 (-> ready for GNOME 2.8).