GNOME Bugzilla – Bug 144529
gtk dialog is not localized
Last modified: 2004-12-22 21:47:04 UTC
Description of Problem: gtkdialog is not localized. Steps to reproduce the problem: 1. Invoke gedit. 2. Choose [File] -> [Open] Actual Results: "Filesystem" in right pane in the dialog is not localized. Expected Results: All is correctly internationalized. How often does this happen? To open the dialog. Additional Information: I attached the patche.
Created attachment 28794 [details] [review] patch for gtk+-2.4.1/gtk/gtkfilechooserdefault.c I added a patch.
Sorry, I cannot file via general forms because Netscape 7.0 on Solaris outputs an error when submit bugs. So I submitted bugs via easy forms.
The patch is wrong, you can't stuff variables in _(), just literal strings. But I can't even reproduce the problem here, "Filesystem" appears nicely localized as "Dateisystem" in German. So maybe it is just that the translation for your locale is incomplete ? Please reopen if you find out that there really is a bug.
I found "Filesystem" is localized on SuSE Linux. So this is a Solaris specific issue. gtk_file_system_volume_get_display_name in gtk+-2.4.1/gtk/gtkfilesystem.c calls gtk_file_system_unix_volume_get_display_name in gtkfilesystemunix.c on Linux. Then the "Filesystem" is localzed. But gtk_file_system_volume_get_display_name calls gtk_file_system_gnome_vfs_volume_get_display_name in libgnomeui-2.6.0/file-chooser/gtkfilesystemgnomevfs.c on Solaris. Then the message is not localized because the domainname is not configured correctly. So I attach the Solaris patch for libgnomeui.
Created attachment 28929 [details] [review] patch for libgnomeui-2.6.0/file-chooser/gtkfilesystemgnomevfs.c I attached the patch.
I see this same problem in gedit and gpdf (and probably all other apps) using Fedora Core 3 test releases. This means it's not a Solaris specific problem at all.
Created attachment 31214 [details] [review] simpler fix should this just include gi18n-lib.h instead of gi18n.h ?
Oops, Christian is right. It should use gi18n-lib.h. Please go ahead and commit.
Commited. Thanks for the prompt fix Christian.