GNOME Bugzilla – Bug 144337
add preview to filechoosers
Last modified: 2018-02-27 18:52:47 UTC
For the filechoosers in open mode (File->Open, and "Browse" on a web form file input field), we should have add a preview; especially now that people seem to work on HTML thumbnailers :) The code can just be copied from galeon which has all we need.
Yeah, let's steal that ! ;)
Created attachment 29134 [details] [review] copied from galeon
Created attachment 29135 [details] [review] simplified the code some more
ephy-file-chooser.c:27:31: ephy-file-preview.h: No such file or directory I'd like to try it out before reviewing ...
Oops,forgot to diff lib/Makefile.am; add -I$(top_srcdir)/lib/widgets \ to INCLUDES
That's prolly wrong. We should move the file picker in lib/widgets
This is just to get it to compile :) I plan to move ephy-file-chooser.[ch] to lib/widgets, but only when I commit (otherwise the diff wouldn't be useful). Should I just cvs remove/cvs add, or ask someone to do cvs surgery?
Created attachment 29162 [details] [review] updated to apply cleanly to cvs HEAD
Comment on attachment 29162 [details] [review] updated to apply cleanly to cvs HEAD This is good to commit, but we decided to punt this until a HTML thumbnailer is available.
Mass reassigning of Epiphany bugs to epiphany-maint@b.g.o
chpe, do you have a bug # for the HTML thumbnailer?
AFAIK there's not bug, but you can get the code here: http://www.netsonic.fi/~temaatti/galeon-html-thumbnailer/
I tried that galeon stolen code but couldn't make it work, actually I was trying to solve the bug about thumbnails for bookmarks.
*** Bug 440859 has been marked as a duplicate of this bug. ***
Isn't this part of GTK, from my limited understanding? (like, just passing one or two commands to the file chooser widget and it shows the preview?) I'm not sure to understand what is the current status of this bug.
Woops, discard my comment #15, I thought my bug #440859 was a dupe of this, turns out it is not ;)
Is this ticket still necessary? In my opinion there shouldn't be a special preview widget as gtk file chooser already shows images. Furthermore additional types should be handled there and not in epiphany.
In fact, it's no longer possible. We can't add preview widgets to native file choosers, which are needed for Flatpak support. The file chooser is no longer run by the epiphany process at all.