After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 143688 - save as query dialog is not having title.
save as query dialog is not having title.
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: general
2.6.x
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
gedit QA volunteers
AP3
Depends on:
Blocks:
 
 
Reported: 2004-06-04 07:03 UTC by Chandrashekhar. Korlahalli
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch which fixes the bug (2.07 KB, patch)
2004-06-09 06:08 UTC, Archana Shah
accepted-commit_now Details | Review

Description Chandrashekhar. Korlahalli 2004-06-04 07:03:33 UTC
-> Open an existing file in gedit.
-> Try to do "Save as" from file menu
-> Go ahead and try to save the file in the same original name.

1. Observation - A Dialog pops up - asking if you want to overwrite/replace the 
already existing file with this new one. Bug - This dialog has no title.

Click on revert in file menu.

2. Obersavetion - a dialog pops up asking if user is sure. 
Bug - This dialog has no title.

Titles are important for the blind user to get a context of the window that is 
in focus. A title saying "error", "Query" or some informative word makes a big 
difference.
Comment 1 Paolo Borelli 2004-06-04 07:21:16 UTC
According to the HIG confirmation dialog should have no title... as a matter of
fact in draft HIG it is argued that they should not even have a title *bar* at all.

I'm not familiar with assistive technologies, but there are probably some other
tricks to make them aware of the dialog since in gnome there are a lot of
confirmation dialogs without title.
Comment 2 bill.haneman 2004-06-04 15:01:02 UTC
The dialog should explicitly have its accessible name set (that is, the toplevel
AtkObject in the dialog's hierarchy should have atk_object_set_name()) called)
if there is no title.

Comment 3 Paolo Maggi 2004-06-07 17:06:47 UTC
Could you guys provide a patch?
Comment 4 Paolo Maggi 2004-06-07 17:07:51 UTC
Could you guys provide a patch?
Comment 5 Archana Shah 2004-06-08 04:00:05 UTC
Yes, I will attach a patch soon.
Comment 6 Archana Shah 2004-06-09 06:08:54 UTC
Created attachment 28488 [details] [review]
Patch which fixes the bug
Comment 7 Paolo Maggi 2004-06-09 11:49:32 UTC
Comment on attachment 28488 [details] [review]
Patch which fixes the bug

The patch looks good.

I have only a doubt:
is "Question" the right accessible name here?
Comment 8 Chandrashekhar. Korlahalli 2004-06-10 12:07:47 UTC
Hi Paolo Maggi,

In my view, Title accessible description  as " Question " felt good, speech 
engine  pronounced very well, & dialog box has a question mark symbol. With all 
above reason I thought accessible description  suites as " Question ".
May be you can suggest alternative to this also.
Comment 9 Paolo Maggi 2004-06-10 14:28:09 UTC
No, I don't have a better suggestion.
Please, commit on CVS HEAD.
Do not commit on gnome-2-6 branch since it breaks string freeze.
Comment 10 bill.haneman 2004-06-10 14:44:18 UTC
Paolo: can Chandrashekar commit to gnome-2-6 if he removes the i18n _() macro?
Comment 11 Paolo Maggi 2004-06-10 15:06:41 UTC
It is not a problem for me.
He could also try to ask to the i18n guys for adding the new string in the
stable branch.
Comment 12 Kaushal Kumar 2004-06-11 13:37:35 UTC
Christian: The patch has a string to be translated.

Couple of options of getting it into the gnome-2-6 branch:-

1) commit it and notify i18n team about the required translation.
2) commit it without the i18n _() macro.

Or, do not commit this patch in gnome-2-6.

Please let know.

For now, I have committed the patch to CVS HEAD on Archana's behalf. The log is
pasted below:-

2004-06-11  Kaushal Kumar <kaushal.kumar@wipro.com>

        Patch by: Archana Shah <archana.shah@wipro.com>
        Approved by: Paolo Maggi <paolo.maggi@polito.it>

        * gedit-file.c (gedit_file_revert_dialog):
        Set accessible name for dialog.

        * gedit-file-selector-utils.c (replace_dialog):
        Set accessible name for dialog.

        Fixes bug #143688.
Comment 13 Danilo Segan 2004-06-12 14:10:43 UTC
Please don't CC gnome-i18n list directly -- there're many subscribers there who
don't need to track all i18n-related bugs.  Also, be sure to use keywords such
as "string", "I18N" and "L10N" if there's a patch waiting for approval from I18N
team.
Comment 14 Kaushal Kumar 2004-06-14 05:40:09 UTC
Sure thing. Thanks Danilo.
Comment 15 Paolo Borelli 2004-06-25 09:57:01 UTC
Danilo and other i18n guys: so is this patch OK or not OK to commit on the
stable branch?
Comment 16 Danilo Segan 2004-06-25 14:03:18 UTC
Paolo, 
The official procedure to follow when asking for string-freeze breakages: 
http://developer.gnome.org/dotplan/tasks.html#ApprovingFreezeBreaks

OTOH, one similar fix was already approved by Christian Rose, but that means
nothing in current case: we need official blessing from him for it to be committed.

Basically, I suggest you now report this to gnome-i18n@gnome.org list, with
detailed reasons (accessibility, etc.) for wanting this to be approved, along
with the link to this bug report.  Then, wait for answer from Christian or
Kjartaan before doing anything.
Comment 17 Paolo Maggi 2004-07-13 14:29:00 UTC
Closing.