GNOME Bugzilla – Bug 143599
Share "show hidden" option with Nautilus
Last modified: 2012-12-07 17:58:17 UTC
Gnome 2.6, Fedora Core 2 Go to: 1) Open Preferences > Themes 2) Choose Install Theme 3) Choose Browse... I have it turned on within nautilus to show directories that start with a period, yet in the Select File dialog, this isn't available, leading to some interesting inabilities to access certain files that I can with nautilus. Please come up with some mechanism to toggle hidden files on and off within this kind of File Select box, and maybe honor the settings for nautilus. I notice that Mozilla Firefox's Select File dialog has a checkbox for this. Please make it so that checkbox is there by default when calling this type of Select File dialog. All Select File dialog called within applications created by Gnome.org should have this checkbox. Consistency is something users want. Applications much up the Select file dialog too much, and this is just one example.
You can press the right mouse button on the file list to get a menu; there you can toggle whether hidden files get displayed. Sharing this option with Nautilus is planned. I'll re-title the bug for clarity.
We still need the checkbox even if this bug is fixed. Having to right click is inconsistent with other "Select File" dialogs that use checkboxes, and is hard ti find. Should I file a seperate bug on having the checkbox available?
I tried right clicking on the file list, and nothing happened. Are you sure you are talking about the same dialog? I'll attach a screenshot.
Created attachment 28278 [details] The screenshot of what I see
*** Bug 148954 has been marked as a duplicate of this bug. ***
Brian, please get GTK+ 2.4.1 or later.
Does this mean it was fixed in 2.4.1?
No. We added a way to display hidden files in 2.4.1, but the setting is not shared with nautilus yet.
Also honour the '.hidden file' will make the integration with nautilus completely in this matter.
Could you please add the hotkey Ctrl+H at the same time?
This is still an issue in Gnome 2.24 (GTK 2.14.4). It is rather important because some files/folders cannot be renamed, so listing them in the .hidden file is the only way to hide them. Unfortunately the latter is not honoured in the filechooser dialogs, as a result these files/folders cannot be hidden from the filechooser.
(Bug #542356 is a duplicate of this bug.) This is still an issue in Gnome 2.26. Not a big one, but a usability issue nonetheless. The present status looks like this: 1. Hidden files can be shown as of GTK 2.4.1 (announced in 2005 in the comments). 2. The Ctrl+H hotkey was added too (requested in 2006 in the comments). 3. Nautilus is now using a global Gnome setting for this: /desktop/gnome/file_views/show_hidden_files. GtkFileChooser doesn't yet. 4. The feature request that ".hidden" files should be taken into account as Nautilus does was neither discussed nor implemented. I think this should be a different bug, so i created one: #596234. 5. On a slightly related note, GtkFileChooser now mimics Nautilus behavior by considering files ending in ~ (like gedit backup files) as hidden files. The implementation is different, as Nautilus has a setting for that and not GtkFileChooser. See bug #355851.
*** Bug 542356 has been marked as a duplicate of this bug. ***
Created attachment 229623 [details] [review] Share hidden setting with GTK This patch is for Nautilus it uses GTK file chooser GSettings for hidden files.
Reassigning to Nautilus. TL;DR - We want Nautilus and GtkFileChooser to share the configuration for "show hidden files". Timothy's patch makes Nautilus use the file chooser's configuration key for this. From a casual look the patch looks fine. I'm not sure if DConf likes it if you just remove a schema like that.
Review of attachment 229623 [details] [review]: Looks mostly good to me, but I think Federico is right, and we shouldn't remove the key from the schema completely. ::: libnautilus-private/org.gnome.nautilus.gschema.xml.in @@ -159,3 @@ - <_summary>Whether to show hidden files</_summary> - <_description>If set to true, then hidden files are shown by default in the file manager. Hidden files are either dotfiles, listed in the folder's .hidden file or backup files ending with a tilde (~).</_description> - </key> It'd be just wrong for applications to depend on the presence of this key in the schema, but yes we should keep it for now, maybe with a comment in the description that it's deprecated and ignored.
Created attachment 230505 [details] [review] Share hidden setting with GTK Updated patch leaving in the key and adding comment as suggested.
Review of attachment 230505 [details] [review]: ::: libnautilus-private/org.gnome.nautilus.gschema.xml.in @@ +155,3 @@ <_description>When a folder is visited this viewer is used unless you have selected another view for that particular folder. Possible values are "list-view", and "icon-view".</_description> </key> + <!-- The "show-hidden-files" key is deprecated and ignored. The "show-hidden" key from "org.gtk.Settings.FileChooser" is now used instead --> I was actually thinking of a comment in the user-visible description - sorry I should have been clearer in my previous review. That is so that people setting the value with an editor that displays the description (e.g. dconf-editor) would see the comment and change the other key when they realize this doesn't have effect anymore.
Created attachment 230573 [details] [review] Share hidden setting with GTK Whoops, yes that makes sense now. I've updated the patch to move the comment to the key description. Also I'll attach a GTK patch to update the key description in the GTK schema as it currently does not have one.
Created attachment 230579 [details] [review] Add summary and decription to key Maybe I should create a separate bug for this? Also for the description to be true the patch for this bug needs to be accetped first: https://bugzilla.gnome.org/show_bug.cgi?id=587806
(In reply to comment #20) > Maybe I should create a separate bug for this? > > Also for the description to be true the patch for this bug needs to be accetped > first: https://bugzilla.gnome.org/show_bug.cgi?id=587806 Yes, please; you can either take the .hidden part out of the description and incorporate it with the patch in bug 587806 or just mark it as a dependency of that bug.
I've create bug #689584 for the key summary and description patch. Also not really related to this bug but thought I would note it he just for anyone following. I have also created a bug #689585 as a reminder to remove the Nautilus specific code that supports .hidden files if/when support is added to Glib.
Review of attachment 230573 [details] [review]: Looks good to me.
Comment on attachment 230579 [details] [review] Add summary and decription to key Marking as obsolete, as it's in the other bug.
Excellent. Can someone with git access push this. Thanks, Tim
Thanks, Tim! Pushed to master as 85524e01c37.